From owner-cvs-all Thu Apr 12 17:29:53 2001 Delivered-To: cvs-all@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 6A1DE37B509; Thu, 12 Apr 2001 17:29:47 -0700 (PDT) (envelope-from dima@unixfreak.org) Received: from hornet.unixfreak.org (hornet [63.198.170.140]) by bazooka.unixfreak.org (Postfix) with ESMTP id 6FE383E25; Thu, 12 Apr 2001 17:29:44 -0700 (PDT) To: Bruce Evans Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Brian Somers Subject: Re: cvs commit: src/bin/ps ps.c In-Reply-To: ; from bde@zeta.org.au on "Thu, 12 Apr 2001 19:50:06 +1000 (EST)" Date: Thu, 12 Apr 2001 17:29:44 -0700 From: Dima Dorfman Message-Id: <20010413002944.6FE383E25@bazooka.unixfreak.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Bruce Evans writes: > On Wed, 11 Apr 2001, Dima Dorfman wrote: > > --- ps.1 2001/04/07 11:22:26 1.32 > > +++ ps.1 2001/04/11 22:22:47 > > @@ -430,6 +430,8 @@ > > .Tn ID > > .It ruser > > user name (from ruid) > > +.It sid > > +session ID > > Should probably be marked up with ".Tn ID" like all the other IDs. Yep, Brian already fixed this. > I'm not sure about the the name change "sess" -> "sid". I thought about this one. Both ways have their advantages. Think of automated scripts that use ps: if they rely on 'sess' on being a unique session identifier, then this change breaks them, although those scripts are easy to fix; if they use 'sess' as something more than a unique value per session, then changing the meaning of 'sess' breaks them. Although I think the latter group is much smaller, those scripts that are in it will break in much more mysterious ways if the name wasn't changed (i.e., things in the first group break with "ps: no sess" messages, while the latter break with possibly incorrect output). That said, I wouldn't mind if someone wanted to change sid and tsid back to sess and tsess, respectively. Dima Dorfman dima@unixfreak.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message