From owner-svn-src-head@freebsd.org Thu Jun 27 03:43:22 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6C65E15D9C10; Thu, 27 Jun 2019 03:43:22 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CE5226CC5D; Thu, 27 Jun 2019 03:43:20 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id gLJchgfslldkPgLJehoSbw; Wed, 26 Jun 2019 21:43:18 -0600 X-Authority-Analysis: v=2.3 cv=Ko4zJleN c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=dq6fvYVFJ5YA:10 a=iKhvJSA4AAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=Vaev78BLB3p2O4-yin8A:9 a=CjuIK1q_8ugA:10 a=odh9cflL3HIXMm4fY7Wr:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 1D5B298F; Wed, 26 Jun 2019 20:43:16 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x5R3hFhO058293; Wed, 26 Jun 2019 20:43:15 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x5R3hFfS058290; Wed, 26 Jun 2019 20:43:15 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201906270343.x5R3hFfS058290@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: rgrimes@freebsd.org cc: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r349450 - head/contrib/ipfilter/tools In-Reply-To: Message from "Rodney W. Grimes" of "Wed, 26 Jun 2019 20:01:54 -0700." <201906270301.x5R31sLH057763@gndrsh.dnsmgr.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 26 Jun 2019 20:43:15 -0700 X-CMAE-Envelope: MS4wfIg/Zlq/oIv5wL4bbI4sF0JJn81o6PA0iEe35zxL2y8Z9KAjNCDC8wTFSLlMjl3Zt9XU+hPuamEvDNKyD70S2T5wnyNFvfAkudbYkgv24nOIyE77Q68r 3+KRWdkp9pP/r93HPsPfQRJ9FOE6i+KNZe/uvBWt1ZusJISR06+wUcwVVWTKGQO0JzgqQY5X2OHQMRHCQSWBnIlSqILRD6WUe1HlWnNVmNytZQmZTRhCZ9zW BndlidxL1OBEQtkIIafNdZ9Rhmtm9MyM2T3pSQBNcIgM86CciwGftAI7Uj6Vd6TlmM9yInQYddfMKP6dR2YODQ== X-Rspamd-Queue-Id: CE5226CC5D X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.99 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; REPLYTO_EQ_FROM(0.00)[]; IP_SCORE(-2.55)[ip: (-6.85), ipnet: 64.59.128.0/20(-3.27), asn: 6327(-2.54), country: CA(-0.09)]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; NEURAL_HAM_SHORT(-0.73)[-0.729,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[12.134.59.64.list.dnswl.org : 127.0.5.1] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jun 2019 03:43:22 -0000 In message <201906270301.x5R31sLH057763@gndrsh.dnsmgr.net>, "Rodney W. Grimes" writes: > > Author: cy > > Date: Thu Jun 27 02:43:30 2019 > > New Revision: 349450 > > URL: https://svnweb.freebsd.org/changeset/base/349450 > > > > Log: > > Update usage() to refect the current state of ipmon. > > > > PR: 238816 > > MFC after: 1 week > > > > Modified: > > head/contrib/ipfilter/tools/ipmon.c > > > > Modified: head/contrib/ipfilter/tools/ipmon.c > > =========================================================================== > === > > --- head/contrib/ipfilter/tools/ipmon.c Thu Jun 27 02:43:26 2019 > (r349449) > > +++ head/contrib/ipfilter/tools/ipmon.c Thu Jun 27 02:43:30 2019 > (r349450) > > @@ -1438,8 +1438,11 @@ printipflog: > > static void usage(prog) > > char *prog; > > { > > - fprintf(stderr, "%s: [-NFhstvxX] [-f ]\n", prog); > > - exit(1); > expected > > > + fprintf(stderr, "Usage: %s [ -abDFhnpstvxX ] [ -B ] [ > -C ]\n" > > + "\t[ -f ] [ -L ] [ -N ]\n" > > + "\t[ -o [NSI] ] [ -O [NSI] ] [ -P ] [ -S ]\n > " > > + "\t[ ]\n", prog); > > + exit(-1); > > Was it intentional to flip the exit code to -1? > Someones scripts might not be prepared for that. My mistake I missed that. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.