From owner-freebsd-net Fri Apr 21 10:53:21 2000 Delivered-To: freebsd-net@freebsd.org Received: from gto.networkphysics.com (DNS1.networkphysics.com [63.194.71.40]) by hub.freebsd.org (Postfix) with ESMTP id BD38237BC79; Fri, 21 Apr 2000 10:53:18 -0700 (PDT) (envelope-from pavel@hemi.networkphysics.com) Received: from hemi.networkphysics.com (hemi.networkphysics.com [10.1.0.30]) by gto.networkphysics.com (8.9.3/8.9.3) with ESMTP id KAA84271; Fri, 21 Apr 2000 10:53:18 -0700 (PDT) (envelope-from pavel@hemi.networkphysics.com) Message-Id: <200004211753.KAA84271@gto.networkphysics.com> To: freebsd-net@FreeBSD.ORG Cc: Robert Watson Subject: Re: NETGRAPH in GENERIC? In-Reply-To: Message from Robert Watson of "Thu, 20 Apr 2000 13:43:22 EDT." Date: Fri, 21 Apr 2000 10:53:18 -0700 From: Tom Pavel Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org >>>>> On Thu, 20 Apr 2000, Robert Watson writes: > Was chatting with Mike online, and we observed that more and more DSL > providers are providing PPPoE by default in many parts of North America. > Right now, this requires recompiling the kernel to support NetGraph as > otherwise you don't get ethernet netgraph nodes. He also observed that > compiling in NetGraph support added only around 20k to his kernel size (I > haven't checked GENERIC). This suggests strongly to me that we should add > NetGraph being to GENERIC, as this would allow kld-loading support for > PPPoE and other spiffy things by default without a kernel recompile. I'm all for this suggestion, but I should point out some oddities I've discovered about KLD-loading the netgraph modules (see http://www.FreeBSD.org/cgi/getmsg.cgi?fetch=35688+39350+/usr/local/www/db/text/2000/freebsd-net/20000319.freebsd-net). Because the ethernet nodes are only created if /sys/net/if_ethersubr.c is compiled with -DNETGRAPH, I think the netgraph.ko module is completely useless and that the netgraph system only works if option NETGRAPH is in the kernel config. This is essentially what Robert said, but I may be overstating the point (for example, if one is only interested in serial-line netgraph uses without ethernet). I propose, however, that having "KMODDEPS=netgraph" in all of the /sys/modules/netgraph/*/Makefile is a mistake, and should be removed. This causes the problem with double copies of the netgraph base code that I reported in the Mar.19 posting cited above, which makes netgraph streams completely fail. I've tested netgraph modules without the dependency, and they work fine for me (with option NETGRAPH and NETGRAPH_SOCKET compiled into my kernel). The real underlying problem may be in the KLD system or how the module declarations are coded in netgraph, but I'm unable to see a solution on that path. With the NETGRAPH option in the GENERIC kernel and the KMODDEPS removed from the individual netgraph modules, I believe everything will work fine. Tom Pavel Network Physics pavel@networkphysics.com / pavel@alum.mit.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message