From owner-freebsd-ports@FreeBSD.ORG Sun Jan 16 21:56:21 2011 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF6341065700 for ; Sun, 16 Jan 2011 21:56:21 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.49.45]) by mx1.freebsd.org (Postfix) with ESMTP id 892048FC18 for ; Sun, 16 Jan 2011 21:56:21 +0000 (UTC) Received: by syn.atarininja.org (Postfix, from userid 1001) id 82A695C3A; Sun, 16 Jan 2011 16:57:08 -0500 (EST) Date: Sun, 16 Jan 2011 16:57:08 -0500 From: Wesley Shields To: Jason Helfman Message-ID: <20110116215708.GA94349@atarininja.org> References: <11111295127072@web122.yandex.ru> <4D3329FE.7020901@yandex.ru> <20110116204416.GA1654@eggman.experts-exchange.com> <4D3361B3.40201@yandex.ru> <20110116214557.GA2179@eggman.experts-exchange.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110116214557.GA2179@eggman.experts-exchange.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: ports@freebsd.org, Ruslan Mahmatkhanov Subject: Re: New port needs review: net/erlyvideo X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 21:56:21 -0000 On Sun, Jan 16, 2011 at 01:45:57PM -0800, Jason Helfman wrote: > On Mon, Jan 17, 2011 at 12:22:59AM +0300, Ruslan Mahmatkhanov thus spake: > >16.01.2011 23:44, Jason Helfman ??????????: > >> On Sun, Jan 16, 2011 at 08:25:18PM +0300, Ruslan Mahmatkhanov thus spake: > >As you can see this patch indeed eliminates using of git, because this > >part isn't really needed for erlyvideo to work. > > > Read this wrong. Thanks, for pointing this out. > > >> You may wish to consider a for loop on the make install target. > >> Are these directories created during the install process of the package? I > >> didn't see these directories created outside of the Makefile. > > > >Do you mean something like this? > > > >DIRS= /var/lib/${PORTNAME}/movies /var/lib/${PORTNAME}/plugins \ > > /var/log/${PORTNAME} ${ERLYDIR} ${ETCDIR} ${WWWDIR} > >.for dir in ${DIRS} > > ${MKDIR} ${dir} > >.endfor > > Yes, however are they created during a pkg_add command? Consider a recent > patch I submitted for comms/minicom. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/153749 > > Directories created in Makefile process, aren't created in the packaging > process, unless you are putting the operations into a pkg-install or an > @exec operation in pkg-plist, respectively. > > That is my understanding, and what I have found in fixing ports here and > there. I fixed the packaging for www/tomcat55, as well. I found that as a > port it worked fine, however package installation would fail. Excuse me if I'm wrong but I think what Jason is getting at is empty directories created when installing the port are not put in the package. This is documented in the handbook: http://www.freebsd.org/doc/en/books/porters-handbook/plist-cleaning.html If these directories are created so that you can install files in them (with INSTALL_FOO macros) then Jason's suggestion is not necessary, because the files will be registered in the package and the directories created automatically when using the package. Not all cases of ${MKDIR} in a port are special. :) -- WXS