From owner-freebsd-net Tue Nov 6 12:50: 6 2001 Delivered-To: freebsd-net@freebsd.org Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by hub.freebsd.org (Postfix) with ESMTP id 6589D37B405 for ; Tue, 6 Nov 2001 12:50:01 -0800 (PST) Received: (from uucp@localhost) by sax.sax.de (8.9.3/8.9.3) with UUCP id VAA24042; Tue, 6 Nov 2001 21:49:53 +0100 (CET) Received: (from j@localhost) by uriah.heep.sax.de (8.11.6/8.11.6) id fA6KSdE66699; Tue, 6 Nov 2001 21:28:39 +0100 (MET) (envelope-from j) Date: Tue, 6 Nov 2001 21:28:39 +0100 From: Joerg Wunsch To: Roman Kurakin Cc: freebsd-net@FreeBSD.ORG, vak@cronyx.ru Subject: Re: kern/11238, kern/14848, kern/21771, sppp patch's patch_id #1 Message-ID: <20011106212839.K43204@uriah.heep.sax.de> Reply-To: Joerg Wunsch References: <000901c1134b$827a69a0$48b5ce90@crox> <3BDABF7B.4060808@cronyx.ru> <3BE24EE4.2020506@cronyx.ru> <20011102192916.A43204@uriah.heep.sax.de> <3BE3ED17.3060603@cronyx.ru> <20011103182927.F43204@uriah.heep.sax.de> <3BE7E1E5.4040500@cronyx.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0.1i In-Reply-To: <3BE7E1E5.4040500@cronyx.ru>; from rik@cronyx.ru on Tue, Nov 06, 2001 at 04:13:09PM +0300 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org As Roman Kurakin wrote: > >Probably. At least it was me who wrote larger parts of the current > >sppp implementation. > Original version was written by Serge Vakulenko ( vak@cronyx.ru > ), Sure. I didn't want to neglect Sergej's part. When i was in need of a PPP implementation for the ISDN project, i picked Sergej's sppp because it looked promising, and i thought it was basically the way i would have gone myself. OTOH, it needed a large overhaul to implement the basic concepts of the PPP RFCs (which you have not much been in need for when using it on hardware HDLC devices). This approximately doubled the size of the source code... that's why the comment above about my part in the current implementation. > and we together keep on > development and fixing current version. Much appreciated! > (we have numerous fixes in PPP and CISCO code and we could offer new > Frame Relay code). Well, to be honest, both should IMHO be broken out into separate files. if_spppsubr.c is overly large already anyway, and both Cisco framing and FR don't have much in comming with SyncPPP except that they incidentally are all three applicable to the hardware HDLC devices Cronyx is producing. ;-) But technically, a user will almost certainly only run one of those framing technologies on his hardware (be it hardware HDLC or ISDN), and it would keep interfaces cleaner to break them out. What do you think? >> The downside of all this is that it takes a FreeBSD committer to do >> it (i expect some two dozens of committs approximately), and >> someone who's got quite a bit of time at hand. > I thought all FreeBSD developers have access to FreeBSD tree? Yes, they have -- but you aren't one, thus i can't simply ask you to do it alltogether. ;-) Unfortunately, with a day job, a small kid, and a couple of other interesting hobbies, my time is fairly limited... I wish i had all of this and much more already done, honestly. -- cheers, J"org .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/ NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message