From owner-svn-src-projects@freebsd.org  Fri Aug 26 23:39:10 2016
Return-Path: <owner-svn-src-projects@freebsd.org>
Delivered-To: svn-src-projects@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EF5E8B76061
 for <svn-src-projects@mailman.ysv.freebsd.org>;
 Fri, 26 Aug 2016 23:39:10 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com
 [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "tensor.andric.com",
 Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id B5CD41CB;
 Fri, 26 Aug 2016 23:39:10 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from coleburn.home.andric.com (coleburn.home.andric.com
 [192.168.0.15])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id 2B98F10EB;
 Sat, 27 Aug 2016 01:39:09 +0200 (CEST)
Subject: Re: svn commit: r304868 - projects/clang390-import/lib/clang
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Content-Type: multipart/signed;
 boundary="Apple-Mail=_3F3ADA8A-B76D-4696-A39E-707A7E548437";
 protocol="application/pgp-signature"; micalg=pgp-sha1
X-Pgp-Agent: GPGMail 2.6.1
From: Dimitry Andric <dim@FreeBSD.org>
In-Reply-To: <CAGHfRMCZ9Ma+9wfFJ+KFkP6KCr6vwE5CHP6fuyDgPvuzpd59PQ@mail.gmail.com>
Date: Sat, 27 Aug 2016 01:39:08 +0200
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-projects@freebsd.org" <svn-src-projects@freebsd.org>
Message-Id: <A241E349-C7E3-490F-ADC9-D25ABCE956B6@FreeBSD.org>
References: <201608262256.u7QMuNaZ037409@repo.freebsd.org>
 <CAGHfRMCZ9Ma+9wfFJ+KFkP6KCr6vwE5CHP6fuyDgPvuzpd59PQ@mail.gmail.com>
To: Ngie Cooper <yaneurabeya@gmail.com>
X-Mailer: Apple Mail (2.3124)
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Aug 2016 23:39:11 -0000


--Apple-Mail=_3F3ADA8A-B76D-4696-A39E-707A7E548437
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On 27 Aug 2016, at 01:12, Ngie Cooper <yaneurabeya@gmail.com> wrote:
> 
> On Fri, Aug 26, 2016 at 3:56 PM, Dimitry Andric <dim@freebsd.org> wrote:
>> Author: dim
>> Date: Fri Aug 26 22:56:23 2016
>> New Revision: 304868
>> URL: https://svnweb.freebsd.org/changeset/base/304868
>> 
>> Log:
>>  Add forgotten {llvm,clang}.pre.mk files.
> ...
>> +LLVM_SRCS=     ${.CURDIR}/../../../contrib/llvm
> 
> Please use ${SRCTOP}/contrib/llvm instead.

I used ${SRCTOP} and ${OBJTOP} initially, until I realized that the
latter didn't work for builds which are started during bootstrap-tools.
So I locally reverted all these changes before committing this WIP.

That said, ${SRCTOP} makes it look a little nicer, but there are lots
of other instances of using ../../.. in these Makefiles.  It does not
really bother me. :)

-Dimitry


--Apple-Mail=_3F3ADA8A-B76D-4696-A39E-707A7E548437
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.30

iEYEARECAAYFAlfA0xwACgkQsF6jCi4glqNQ/QCeKeOwa5hZYEJEnAe94gf11t5e
h4EAnReJPjYuT7JBJsP3GFd/HZ0SCO39
=Okgk
-----END PGP SIGNATURE-----

--Apple-Mail=_3F3ADA8A-B76D-4696-A39E-707A7E548437--