From owner-svn-src-head@freebsd.org Tue Dec 1 16:31:30 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3C66A3E4B4; Tue, 1 Dec 2015 16:31:30 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from mr11p00im-asmtp001.me.com (mr11p00im-asmtp001.me.com [17.110.69.252]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8A3701934; Tue, 1 Dec 2015 16:31:30 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from [192.168.1.4] (c-24-6-178-251.hsd1.ca.comcast.net [24.6.178.251]) by mr11p00im-asmtp001.me.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NYO00FC8TWAFU20@mr11p00im-asmtp001.me.com>; Tue, 01 Dec 2015 16:31:24 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-12-01_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 kscore.is_bulkscore=0 kscore.compositescore=1 compositescore=0.9 suspectscore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 rbsscore=0 spamscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1510090000 definitions=main-1512010264 User-Agent: Microsoft-MacOutlook/0.0.0.151105 Date: Tue, 01 Dec 2015 08:31:22 -0800 Subject: Re: svn commit: r291592 - head/usr.bin/netstat From: Ravi Pokala Sender: "Pokala, Ravi" To: Hajimu UMEMOTO , Ravi Pokala Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-id: <70ADB754-1404-4666-864C-D8E051F59409@panasas.com> Thread-topic: svn commit: r291592 - head/usr.bin/netstat References: <201512011604.tB1G4pHa000698@repo.freebsd.org> <319A5F79-53CD-40A1-9076-CF3EF33858A9@panasas.com> In-reply-to: MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2015 16:31:30 -0000 -----Original Message----- From: Hajimu UMEMOTO Date: 2015-12-01, Tuesday at 08:26 To: Ravi Pokala Cc: , , Subject: Re: svn commit: r291592 - head/usr.bin/netstat >Hi, > >>>>>> On Tue, 01 Dec 2015 08:13:41 -0800 >>>>>> Ravi Pokala said: > >rpokala> The value returned by p_sockaddr("destination", ...) is saved to "protrusion", but it is never used before it is overwritten by the value returned by p_sockaddr("gateway", ...). That doesn't seem right. > >The protrusion is given to the argument of next p_sockaddr() call. How did I miss that? Looks like it's time for new glasses. :-/ -Ravi >Sincerely, > >-- >Hajimu UMEMOTO >ume@mahoroba.org ume@FreeBSD.org >http://www.mahoroba.org/~ume/