From owner-freebsd-git@freebsd.org Wed Mar 1 11:51:55 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DD145CF395C for ; Wed, 1 Mar 2017 11:51:55 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id CAE53BBB for ; Wed, 1 Mar 2017 11:51:55 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id CA2A6CF395B; Wed, 1 Mar 2017 11:51:55 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C823BCF395A for ; Wed, 1 Mar 2017 11:51:55 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 848BBBB8; Wed, 1 Mar 2017 11:51:55 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from [172.16.5.2] (vega.codepro.be [IPv6:2a01:4f8:162:1127::3]) (Authenticated sender: kp) by venus.codepro.be (Postfix) with ESMTPSA id 057441EC6F; Wed, 1 Mar 2017 12:51:52 +0100 (CET) From: "Kristof Provost" To: "=?utf-8?q?Bart=C5=82omiej?= Rutkowski" Cc: "Warner Losh" , git@freebsd.org Subject: Re: pull requests Date: Wed, 01 Mar 2017 12:52:13 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: MailMate (2.0BETAr6080) X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 11:51:56 -0000 On 1 Mar 2017, at 10:36, Bartłomiej Rutkowski wrote: > What kind of policy, regarding what and 'policing' what and how > exactly? > Who and how will enforce such policy and on whom? In the end, "we > can't > force anyone to do anything" so unless we commit to do something on > GitHub, > I'd see it as a dead law. > There is an official FreeBSD account on GitHub and I don’t expect that to go away. See https://github.com/freebsd/freebsd/pulls (As an aside, I note that someone has been cleaning these up. Awesome.) We are getting pull requests there and something should be done with them. > Not to mention I've got a feeling this is completely disconnected from > the > general direction that I think has been 'agreed', that is we'll have a > software solution getting GH PR's into Phabric reviews and GH Issues > into > Bugzilla PR's automatically. What then, shouldn't it be more like > Phabric > reviews/Bugzilla PR policy instead? > This is probably a good answer to the question of what to do with those pull requests. As the current situation is “they’re completely ignored” anything would be an improvement. Even automatically closing them with “Go to instead.” would be an improvement. It might be nice to document a review policy (usable for GitHub, Phabricator, e-mail reviews, …) somewhere. Things like “How long do I wait for reviews?”, “Who do I subscribe/cc/…?”, “What should be done with abandoned reviews?” … I fully support Warner’s efforts. Regards, Krsitof