From owner-svn-ports-all@freebsd.org Mon Jun 24 19:55:08 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05DCA15D7B16; Mon, 24 Jun 2019 19:55:08 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9F37C85AB7; Mon, 24 Jun 2019 19:55:07 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: by mail-qt1-x836.google.com with SMTP id a15so15851635qtn.7; Mon, 24 Jun 2019 12:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qaJZ6Yjxhofe7W+0fF7R9r9AspOmhqWcGV/+oP1NFus=; b=i2DSHl1dOylymUXxvtmuSG+DG+ra/tsVH60DRxkjNwWK6DAOQeSIy45euYIZOLPF0M p7ObBG6qeqnZAJhl9cuNexp3jV1qUjQxa6Ct8klJMuvpIW2NoK3TcFHOUAT4IFvZ8s4o TO5C1QafFwSXTeGa+pei9A2BnD7Fzxjh3LfHnCozevmt+rMCPEUEd3uhcmRsT0LJ8FpM SfcjQqWuIq/GYbyyyBxBKj04SnQvqUdUh45eBVL1XIhJIBN7nlQy8ztnJEx48XIAOYfA AV3IowZdifbzUj6EM6CkFQ5yTR+lC4ohehZv5D5dE7/JxM7fhpvMws/L9acl9/SSxAXw VS3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qaJZ6Yjxhofe7W+0fF7R9r9AspOmhqWcGV/+oP1NFus=; b=CVT0vuQph8sEB+v0QZ1ryKnSYE+cUMQqNarbM8+IwLULWGDGCPw/dfCzFBnINyU9qK HEpxJ4p7MjvMkFgOM8fGI4f5Ygby88/5cVfaekZRLWt7skQqr5MODgaY5gkwT0HYSjy5 oxwZy2QkO288eIhD23sBZ3HXNRsHiNhu7dmiQKWw7t/f08LCAysf2wm1QvgIlm+I2sVe n4fN+nkiHPzAMjFFSx6I4LeeOIa6DUJdUO8jkh75B8qILJGnG1/QV7zNnQ+F3Gr+SCNE 6MwkvFSdEhVeNtwUmqha0aEpT3xW2aQ/xb6eiEk8xyAZEK8Rwbukb+Z0J4ltpFF9Ku8m 912g== X-Gm-Message-State: APjAAAVG9ZKThwPxVRpVoIxPkE+6MPCJsbBfUrAjctEMzZGUl82TQSsV eRCzDUi7PywXlSeb8CNGVdWJwHipJjL/j44Xjnh+qQ== X-Google-Smtp-Source: APXvYqxyC3UVLo1iGPJdMe+kTuxBaABKD/OI5DHGAVH0PIEDGeF9OtjL8zx/hcIUCan7Io1tB8MCSaIO067gvO2rKoM= X-Received: by 2002:ac8:16ac:: with SMTP id r41mr132462160qtj.346.1561406106942; Mon, 24 Jun 2019 12:55:06 -0700 (PDT) MIME-Version: 1.0 References: <201906241810.x5OIAu1h080487@repo.freebsd.org> <20190624194627.GB49520@ThinkPad-X200.g.anongoth.pl> In-Reply-To: <20190624194627.GB49520@ThinkPad-X200.g.anongoth.pl> From: "Tobias C. Berner" Date: Mon, 24 Jun 2019 21:54:56 +0200 Message-ID: Subject: Re: svn commit: r505045 - head/sysutils/plasma5-ksysguard To: Piotr Kubaj Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org X-Rspamd-Queue-Id: 9F37C85AB7 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.94)[-0.940,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jun 2019 19:55:08 -0000 I set maintainer feedback, because I, as the maintainer gave you the feedback, that "I think this is wrong" :) If I liked that patch, I would have set the patch-approved flag on it. All that said, thanks for "fixing" it, but I still would prefer a real fix, that we can upstream rather than that. mfg Tobias On Mon, 24 Jun 2019 at 21:46, Piotr Kubaj wrote: > Oh, I didn't use "implicit". Doesn't maintainer-feedback + mean that it's > accepted? > > On 19-06-24 21:34:09, Tobias C. Berner wrote: > >Moin moin > > > >Sorry, but I explicitely did not approve this :) so using implicit on it, > >is a bit of a crappy move. > > > >mfg Tobias > > > >On Mon, 24 Jun 2019 at 20:11, Piotr Kubaj wrote: > > > >> Author: pkubaj > >> Date: Mon Jun 24 18:10:55 2019 > >> New Revision: 505045 > >> URL: https://svnweb.freebsd.org/changeset/ports/505045 > >> > >> Log: > >> sysutils/plasma5-ksysguard: fix build with GCC-based architectures > >> > >> Link with libinotify explicitly to fix linking on GCC architectures. > >> > >> PR: 238702 > >> Approved by: tcberner (maintainer, mentor) > >> > >> Modified: > >> head/sysutils/plasma5-ksysguard/Makefile > >> > >> Modified: head/sysutils/plasma5-ksysguard/Makefile > >> > >> > ============================================================================== > >> --- head/sysutils/plasma5-ksysguard/Makefile Mon Jun 24 18:07:12 2019 > >> (r505044) > >> +++ head/sysutils/plasma5-ksysguard/Makefile Mon Jun 24 18:10:55 2019 > >> (r505045) > >> @@ -23,5 +23,6 @@ OPTIONS_SUB= yes > >> > >> INOTIFY_DESC= Filesystem alteration notifications using > inotify > >> INOTIFY_LIB_DEPENDS= libinotify.so:devel/libinotify > >> +INOTIFY_LDFLAGS= -linotify > >> > >> .include > >> > >> > > > >-- > >This message has been scanned for viruses and > >dangerous content by MailScanner, and is > >believed to be clean. > > >