From owner-svn-src-head@freebsd.org Sun Oct 30 22:19:53 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4CE9CC2777D; Sun, 30 Oct 2016 22:19:53 +0000 (UTC) (envelope-from lwhsu@FreeBSD.cs.nctu.edu.tw) Received: from FreeBSD.cs.nctu.edu.tw (freebsd2.cs.nctu.edu.tw [140.113.17.206]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1DDAD170C; Sun, 30 Oct 2016 22:19:52 +0000 (UTC) (envelope-from lwhsu@FreeBSD.cs.nctu.edu.tw) Received: by FreeBSD.cs.nctu.edu.tw (Postfix, from userid 1058) id 3CC632919; Mon, 31 Oct 2016 06:19:51 +0800 (CST) Date: Mon, 31 Oct 2016 06:19:51 +0800 From: Li-Wen Hsu To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r308107 - in head/sys/modules/bhnd: . bcma bcma_bhndb bhndb bhndb_pci cores/bhnd_pci cores/bhnd_pci_hostb cores/bhnd_pcib siba siba_bhndb Message-ID: <20161030221951.GA86782@FreeBSD.cs.nctu.edu.tw> References: <201610301556.u9UFuhAi009407@repo.freebsd.org> <4862480.RxOcpDe54A@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: <4862480.RxOcpDe54A@ralph.baldwin.cx> User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Oct 2016 22:19:53 -0000 --liOOAslEiF7prFVr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 30, 2016 at 15:05:49 -0700, John Baldwin wrote: > On Sunday, October 30, 2016 03:56:43 PM Li-Wen Hsu wrote: > > Author: lwhsu (ports committer) > > Date: Sun Oct 30 15:56:42 2016 > > New Revision: 308107 > > URL: https://svnweb.freebsd.org/changeset/base/308107 > >=20 > > Log: > > - Fix `make` in sys/modules/bhnd > > =20 > > Approved by: landonf > > Differential Revision: https://reviews.freebsd.org/D7774 >=20 > This is wrong. bhnd_debug.h should not have '#include opt_global.h'. It= is > included implicitly during kernel builds via '-include' in CFLAGS. It is > always incorrect to include it explicitly in source. This should be > reverted and bhnd_debug.h should be fixed instead. Got it, reverted in r308115. --=20 Li-Wen Hsu https://lwhsu.org --liOOAslEiF7prFVr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJYFnIGXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQxMDdENTNGNjUyMTUzMzVCNzA5NDNGODQ2 NzI3RTc3Qzg4NjJCNjU2AAoJEGcn53yIYrZWvRIP/3HbcDartsocVKvlsoaG5E1W BG7yyDvo2NsmxgE0zq7ismBqmFYQDIMfKaD5Fuxsma3yVuSrUUlIxjp0t8igaISw Q2k0AS4fkazLhAQERHIo3EpjmBgIapI9q6Bm34gXL4zDARuWN+F9lifs5Cf+Q3lf UcdGshhnl+xsRpYjQ00mz+VBeNYWwBIoLdy34aAGVu/SUuXZkKIskhHWIeEQi7Cw /w+BRefEM3eyR0SybkbXBeDJQir9C584cFOPVb17bmUnD+U6HiVrdQMYvhzbkJbT YVbE2CgzqGcVsv7LqV1skxV6iO8mzQ9K9i4z76xgHGaXwMRrizD4pCruzu/UJ10V b/fKpmzMia7Pshs+HGw7wpF2CUFudVpibLZGCExflXffmDB4nnC/tU6K/t4Dl3GC 4F1GwEwekjBdtOsxNfeU0/K0UAfcBU7K/VMiQ19Ajmpn79hYUAgm0AIH23Ye9BHu aEEzKC3KNSu4Jgu9zjSN0UpxPzFDNGVwrEMM8JtYucBW0qvfRxEHlnWCRGR6axHp gxWizyCF1Gn3bP94sPGz261kNgOmWkS3vrEIAvNHImXOXwVil1J3n38OCRF448Ft ta92OXakOY9Yna6vSwr/8+G/LAn0IvLZ+t567RQjb5DcmezuFC7sJV7qwPge8JPB i1jvUH53y6SumMey2G8g =+gYj -----END PGP SIGNATURE----- --liOOAslEiF7prFVr--