From owner-freebsd-current  Fri Jun 21 15: 9:37 2002
Delivered-To: freebsd-current@freebsd.org
Received: from creme-brulee.marcuscom.com (rdu57-17-158.nc.rr.com [66.57.17.158])
	by hub.freebsd.org (Postfix) with ESMTP id 1AB0237B401
	for <freebsd-current@FreeBSD.ORG>; Fri, 21 Jun 2002 15:07:13 -0700 (PDT)
Received: from shumai.marcuscom.com (marcus@shumai.marcuscom.com [192.168.1.4])
	by creme-brulee.marcuscom.com (8.12.3/8.12.3) with ESMTP id g5LM4pB4058935;
	Fri, 21 Jun 2002 18:04:51 -0400 (EDT)
	(envelope-from marcus@marcuscom.com)
Subject: Re: The -current state of mozilla affairs
From: Joe Marcus Clarke <marcus@marcuscom.com>
To: Alexander Kabaev <ak03@gte.com>
Cc: freebsd-current@FreeBSD.ORG, sean@chittenden.org
In-Reply-To: <20020621155921.79fc4c91.ak03@gte.com>
References: <3CFC588A.9070903@sbcglobal.net>
	<20020604134655.B62465@xor.obsecurity.org>
	<20020619183056.K31745@ninja1.internal>
	<1024539159.44782.21.camel@shumai.marcuscom.com>
	<20020619232135.D37593@ninja1.internal>
	<20020620102527.C55653@dragon.nuxi.com>
	<1024597364.329.26.camel@gyros.marcuscom.com> 
	<20020621155921.79fc4c91.ak03@gte.com>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature";
	boundary="=-TWub3A2AtF2O2bOY5iiZ"
X-Mailer: Ximian Evolution 1.0.7 
Date: 21 Jun 2002 18:07:50 -0400
Message-Id: <1024697270.58209.24.camel@shumai.marcuscom.com>
Mime-Version: 1.0
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG


--=-TWub3A2AtF2O2bOY5iiZ
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Fri, 2002-06-21 at 15:59, Alexander Kabaev wrote:
> Why not to use GCC version itself to distinguish between
> thunked/non-thunked vtable implementations?=20

The full comments in the header file illustrate why the Mozilla teamed
keyed off of the internal compiler revision.  Basically, almost all
ports-based compilers were thunked, and there was a short period of time
in early 4.0 when a thunked system GCC was in the tree.

Note, we are using the FreeBSD compiler revision, and not
__FreeBSD_version in this header.

Joe

>=20
> > > Please add a comment why you chose these __FreeBSD_cc_version
> > > values. What is special about 500003?  500003 is 5.0-CURRENT after
> > > buf/bio changes, *years* ago.  Perhaps you wanted another value from
> > > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/fre=
ebsd-versions.html
> >=20
> > Fear not.  I'm modifying the patch.  Proper documentation will be
> > included.
> >=20
> > Joe
> --=20
> Alexander Kabaev
>=20


--=-TWub3A2AtF2O2bOY5iiZ
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iD8DBQA9E6O2b2iPiv4Uz4cRAlPOAKClYSZblefUJMygjce4i2eBZxl67wCfThuN
PYL5hWaMjpQ9AY164NJxFBY=
=PC4O
-----END PGP SIGNATURE-----

--=-TWub3A2AtF2O2bOY5iiZ--


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message