From owner-dev-commits-src-main@freebsd.org Fri May 7 18:26:50 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5031163849A for ; Fri, 7 May 2021 18:26:50 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FcJnQ1Ls9z3CLN for ; Fri, 7 May 2021 18:26:50 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x732.google.com with SMTP id l129so9414749qke.8 for ; Fri, 07 May 2021 11:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Wx2J9lZbvyil11aXmUljDYAfXeC7cjj8whhiKZL9dzQ=; b=yvr8Y6zMqAdMVhRO9Astbi9P6Fvz57IF3AZDyuROLzcn3yhzXfnI1D9s9aBXZD0PcN XwwM9GOUFbtpFSLWn16BmxdxGT0r5YIiS5JzhB/s4+6nJy309oObejDyZrFdbNxVthky lBGDGIkd6M1s2LUVSYV+xxw47hDdHvzCy84+KMVdjND4eJg9HsXv5sh9KZ6fdzq60rbJ w7xoq5wmginZ//5s/cpFNxbvhLVywS8uBIUmafEBpVfzkbsuSyUP29pAY+UCv2mj2u8D 6zvJTGjn6KYGH5RhSZJZytPeU6dL6cIBndukxBlC5QzI6scYWqKjT+Vk/yodYaCNquHr b80A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wx2J9lZbvyil11aXmUljDYAfXeC7cjj8whhiKZL9dzQ=; b=SxxRGWYbdZrvPRA48IG83lBD33X/rJqzGKlHYFLJN8sBLaMuwvu/OHxP3Q48a8XnXs gLZkXgiDbO/NZh5gU9GDAQ0DWimqpSe0TL8pWONyiSZh69NGUSXj4MAdHooItQcd+/nS K8p1/rJZrOysoJVs6KpO9TG2CQmOG0owoAqk5sy0afe8upbaVC6RgZHpMukTMi99d5dS yppdedhlXHcvQz5jJPNuqv9NG40rbAuR4e3KQyXK3aaG2lqTIeuoAgqzbfBviMMLrE7O 5ej85Q3xA1ahIkeZRmJ7qUGBn1HoN+rRnYkQ8m2h9SPqgu4/ieFhezsV0Q5AM0kCHLiz F0IQ== X-Gm-Message-State: AOAM53296i8j1pDFvz1amb90reXxMyGc/8E926wej79ebFAAhH4mEBv1 P4ZxhHbQUEitApzuhvoLj6KZy08WQyNrD2qF3q+e9Q== X-Google-Smtp-Source: ABdhPJxojc4lHIhtsqS5CP0vImWjKzNS72dGiW1RFG1gWMNKxSpSJ2qn6g4YHChmpGK3W4nz6WvZ/lGkCSs10Y7u1sw= X-Received: by 2002:a37:c444:: with SMTP id h4mr8411376qkm.206.1620412009164; Fri, 07 May 2021 11:26:49 -0700 (PDT) MIME-Version: 1.0 References: <202105061526.146FQS0E008755@gitrepo.freebsd.org> <78FF7B31-B84D-4D97-9E57-D000A6B09D7D@macmic.franken.de> In-Reply-To: <78FF7B31-B84D-4D97-9E57-D000A6B09D7D@macmic.franken.de> From: Warner Losh Date: Fri, 7 May 2021 12:26:37 -0600 Message-ID: Subject: Re: git: 5d8fd932e418 - main - This brings into sync FreeBSD with the netflix versions of rack and bbr. This fixes several breakages (panics) since the tcp_lro code was committed that have been reported. Quite a few new features are now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the largest). There is also support for ack-war prevention. Documents comming soon on rack.. To: Michael Tuexen Cc: Gordon Bergling , Li-Wen Hsu , Randall Stewart , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4FcJnQ1Ls9z3CLN X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2021 18:26:50 -0000 https://reviews.freebsd.org/D30163 May be the ticket to solve this... Warner On Fri, May 7, 2021, 12:03 PM Michael Tuexen < michael.tuexen@macmic.franken.de> wrote: > > On 7. May 2021, at 19:47, Gordon Bergling wrote: > > > > On Fri, May 07, 2021 at 05:39:37PM +0800, Li-Wen Hsu wrote: > >> On Thu, May 6, 2021 at 11:26 PM Randall Stewart > wrote: > >>> > >>> The branch main has been updated by rrs: > >>> > >>> URL: > https://cgit.FreeBSD.org/src/commit/?id=5d8fd932e418f03e98b3469c4088a36f0ef34ffe > >>> > >>> commit 5d8fd932e418f03e98b3469c4088a36f0ef34ffe > >>> Author: Randall Stewart > >>> AuthorDate: 2021-05-06 15:22:26 +0000 > >>> Commit: Randall Stewart > >>> CommitDate: 2021-05-06 15:22:26 +0000 > >>> > >>> This brings into sync FreeBSD with the netflix versions of rack and > bbr. > >>> This fixes several breakages (panics) since the tcp_lro code was > >>> committed that have been reported. Quite a few new features are > >>> now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the > >>> largest). There is also support for ack-war prevention. Documents > >>> comming soon on rack.. > >>> > >>> Sponsored by: Netflix > >>> Reviewed by: rscheff, mtuexen > >>> Differential Revision: https://reviews.freebsd.org/D30036 > >> > >> This seems braking LINT kernel build of powerpc: > >> > >> https://ci.freebsd.org/job/FreeBSD-main-powerpc-LINT/6082/console > >> > >> Searching "error:" leads to: > >> > >> 00:08:15.153 > /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2143:16: > >> error: implicit declaration of function 'tcp_hw_highest_rate' is > >> invalid in C99 [-Werror,-Wimplicit-function-declaration] > >> 00:08:15.153 high_rate = > >> tcp_hw_highest_rate(rack->r_ctl.crte); > >> 00:08:15.153 ^ > >> > >> and > >> > >> 00:08:15.163 > /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2165:16: > >> error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is > >> invalid in C99 [-Werror,-Wimplicit-function-declaration] > >> 00:08:15.163 high_rate = > >> tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, > >> rack->rc_inp); > >> 00:08:15.163 ^ > >> > >> I suspect this is because RATELIMIT is not defined in default powerpc > >> build? Is it safe to enable it? > >> > >> Best, > >> Li-Wen > > > > That should not be something RATELIMT related. I regular test 14-CURRENT > on a > > RPi4B and the build today fails with > > > > -------------------------------------------------------------- > >>>> stage 3.1: building everything > > -------------------------------------------------------------- > > > /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2143:16: > error: implicit declaration of function 'tcp_hw_highest_rate' is invalid in > C99 [-Werror,-Wimplicit-function-declaration] > > high_rate = tcp_hw_highest_rate(rack->r_ctl.crte); > > ^ > > > /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2165:16: > error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is > invalid in C99 [-Werror,-Wimplicit-function-declaration] > > high_rate = > tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, > rack->rc_inp); > > ^ > > > /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:14166:15: > error: implicit declaration of function 'tcp_hw_highest_rate' is invalid in > C99 [-Werror,-Wimplicit-function-declaration] > > high_rate = tcp_hw_highest_rate(rack->r_ctl.crte); > > ^ > > > /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:14193:15: > error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is > invalid in C99 [-Werror,-Wimplicit-function-declaration] > > high_rate = > tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, > rack->rc_inp); > > ^ > > 4 errors generated. > > --- rack.o --- > > *** [rack.o] Error code 1 > > > > > > RATELIMIT is included in my KERNCONF since I use tcp_bbr(4) for a > > while on the RPi4B now. > Can you post the kernel config you are using? I'm building the kernel on > an arm64 platform by using > > tuexen@parallels:~/freebsd-src/sys/arm64/conf % cat SCTP > include GENERIC > ident SCTP > > makeoptions WITH_EXTRA_TCP_STACKS=1 > options SCTP > options SCTP_DEBUG > options TCPHPTS > options TCP_BLACKBOX > options RATELIMIT > options DEBUG_REDZONE > options IPFIREWALL > options IPFIREWALL_VERBOSE > options IPFIREWALL_VERBOSE_LIMIT=5 > options IPFIREWALL_DEFAULT_TO_ACCEPT > > It looks like RATELIMIT is not defined, when tcp_ratelimit.h is included... > > Best regards > Michael > > > --Gordon > >