From owner-svn-src-all@freebsd.org Tue May 31 06:31:59 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA98AB5591E; Tue, 31 May 2016 06:31:59 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [64.62.153.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anubis.delphij.net", Issuer "StartCom Class 1 DV Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C62F512FC; Tue, 31 May 2016 06:31:59 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from Xins-MBP.home.us.delphij.net (unknown [IPv6:2601:646:9b80:c0a9:d18b:aaca:6b34:b814]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id 47FF8CD44; Mon, 30 May 2016 23:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphij.net; s=anubis; t=1464676313; x=1464690713; bh=MfKXOcN8k4NzVnc55X9gKRZqMAhOI1eltl7+W1s0PMA=; h=Subject:To:References:Cc:From:Date:In-Reply-To; b=fOcwWAzZtpz5mc7y91qF4Yub2p9gvVHw8ivdPnH/y61Hsz8oIIpT5u6Squ0VuGAr9 ajpDcgDMzKyah7iaOXvrymnhmdICfYoE8FPkIo4X88woaltASwnyPASaVf2FMGNTba Za3cvMYDjnm9mKritMTsWOTtj3V6UTZPtP8WlcN8= Subject: Re: svn commit: r301023 - head/sys/boot/geli To: Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201605310624.u4V6OAYi071387@repo.freebsd.org> Cc: d@delphij.net, Allan Jude From: Xin Li Message-ID: <31d1323b-cb13-9a90-8b25-430fdbc1d225@delphij.net> Date: Mon, 30 May 2016 23:31:48 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <201605310624.u4V6OAYi071387@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3KalNdK6TM0hUh0rgiuR2Bj2SpsJDWHNA" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2016 06:32:00 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3KalNdK6TM0hUh0rgiuR2Bj2SpsJDWHNA Content-Type: multipart/mixed; boundary="8c5pqQjh5u0PStkRWdp8Lrn6BXaVTitai" From: Xin Li To: Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: d@delphij.net, Allan Jude Message-ID: <31d1323b-cb13-9a90-8b25-430fdbc1d225@delphij.net> Subject: Re: svn commit: r301023 - head/sys/boot/geli References: <201605310624.u4V6OAYi071387@repo.freebsd.org> In-Reply-To: <201605310624.u4V6OAYi071387@repo.freebsd.org> --8c5pqQjh5u0PStkRWdp8Lrn6BXaVTitai Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 5/30/16 23:24, Garrett Cooper wrote: > Author: ngie > Date: Tue May 31 06:24:09 2016 > New Revision: 301023 > URL: https://svnweb.freebsd.org/changeset/base/301023 >=20 > Log: > Add missing libc includes to fix -Wimplicit-function-declaration warn= ings > =20 > MFC after: 2 weeks > Reported by: clang > Sponsored by: EMC / Isilon Storage Division >=20 > Modified: > head/sys/boot/geli/geliboot_crypto.c >=20 > Modified: head/sys/boot/geli/geliboot_crypto.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/boot/geli/geliboot_crypto.c Tue May 31 06:00:18 2016 (r301= 022) > +++ head/sys/boot/geli/geliboot_crypto.c Tue May 31 06:24:09 2016 (r301= 023) > @@ -27,6 +27,10 @@ > * $FreeBSD$ > */ > =20 > +#include > +#include > +#include > + > #include "geliboot.h" This is wrong, you shouldn't use standard C library in freestanding environment. It seems that libstand.h is explicitly excluded, why? (in geliboot.h, allanjude cc'ed): %%% /* AES-XTS implementation */ #define _STAND #define STAND_H /* We don't want stand.h in {gpt,zfs,gptzfs}boot */ #include %%% Cheers, --8c5pqQjh5u0PStkRWdp8Lrn6BXaVTitai-- --3KalNdK6TM0hUh0rgiuR2Bj2SpsJDWHNA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIbBAEBCgAGBQJXTS/XAAoJEJW2GBstM+nsfNEP+Of3Td8mbIgcBHCfNlXaqHKy RVTckLPVP9eybJEH9L0FXORQC+jPNxWOlMp31s/Mr/3RgKzxSVypiTiLjWh9q6l1 p8CD4GrjkcqYAVcdw3cu7NS6HrAjKQkR0QJoZBNC2dX00DTtQYWudOzYCBxPZQC6 zr3f1+Pmo4jw9MB1/CIn1cxbhUUv5Txdz3yWfD1J/EVNoxQUvgVjEo/Dp3W/swcX T+e4E/paFFWddiTGpff9B9d6n8GE4PaRnsPIHVXLWkCbp7f4PuIlhBf56dls9yxQ ysrX5icZGpew4bQpaaYbn/SG9F0n6XuU/SdA5HTmtK4EaLZvmD38pc8WzW1AH+ey iHdhJC2F1r20jTPqPx8pdb5zZdNW3bPdDJ5Ouqsz537F13/99QH4yPK+nj0s52KF qpvGJMDHQHgGt/gE8OBlltqJb33khlc5Srulp1A7Wk6l7FDA5VG+JDucrVjvv0O0 xBf5KEuoKqSnb7YqgfS2Q6Hxf8MCmnoEBImZW05NnSjqI6N2lWl4ksu0ELkogdfP hVZBOSI976N6NzUa529/jzPSZosW6v8eyS7j3VL1DxvRqcMDvsTgTWBQ9gjNT1II OIimo9l6EpkilXySEVSXJf/rV1C5Q5XQukfTw1w+ZzsDH0+mm8cnm46xMsDWl7my WwFKWR500ubgzKKtxi4= =3XIz -----END PGP SIGNATURE----- --3KalNdK6TM0hUh0rgiuR2Bj2SpsJDWHNA--