From owner-freebsd-bugs@FreeBSD.ORG Fri Oct 28 18:40:24 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BDA6A16A42D for ; Fri, 28 Oct 2005 18:40:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 886FC43D45 for ; Fri, 28 Oct 2005 18:40:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9SIeO9W074790 for ; Fri, 28 Oct 2005 18:40:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j9SIeOCe074789; Fri, 28 Oct 2005 18:40:24 GMT (envelope-from gnats) Date: Fri, 28 Oct 2005 18:40:24 GMT Message-Id: <200510281840.j9SIeOCe074789@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Brooks Davis Cc: Subject: Re: bin/88119: [patch] partial matching for ifconfig X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Brooks Davis List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2005 18:40:25 -0000 The following reply was made to PR bin/88119; it has been noted by GNATS. From: Brooks Davis To: Ben Wilber Cc: freebsd-gnats-submit@freebsd.org Subject: Re: bin/88119: [patch] partial matching for ifconfig Date: Fri, 28 Oct 2005 11:39:57 -0700 Nice idea. I'm not convinved of the implementation though. First, the isdigit() check is bogus because of interface renaming. You might well want to match all the wan interfaces on a system with a naming scheme like lax-wan, sfo-wan, sea-wan. I suspect it may also break "ifconfig gif create". Second, this turns something that was previously an error into something that works which may be confusing. My suggestion would be to implement a new flag, probably -e, which implements egrep style matching using regex(3) (usr.bin/pkill looks like a good example.) This would be both more powerful and avoid the whole issue of POLA violations. -- Brooks