From owner-freebsd-stable@freebsd.org Tue Oct 13 08:16:52 2015 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 47CCAA116F0 for ; Tue, 13 Oct 2015 08:16:52 +0000 (UTC) (envelope-from ck-lists@cksoft.de) Received: from mx1.cksoft.de (mx1.cksoft.de [IPv6:2001:67c:24f8:1::25:1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.cksoft.de", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 017D3AAC; Tue, 13 Oct 2015 08:16:52 +0000 (UTC) (envelope-from ck-lists@cksoft.de) Received: from m.cksoft.de (unknown [IPv6:2a01:170:1110:8001::25:1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.cksoft.de (Postfix) with ESMTPSA id 27F101E9EB2; Tue, 13 Oct 2015 10:16:48 +0200 (CEST) Received: from amavis.cksoft.de (unknown [IPv6:2a01:170:1110:8001::25:a1]) by m.cksoft.de (Postfix) with ESMTP id A155363348; Tue, 13 Oct 2015 10:15:15 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from m.cksoft.de ([192.168.64.93]) by amavis.cksoft.de (amavis.cksoft.de [192.168.64.94]) (amavisd-new, port 10041) with ESMTP id QjGpJDNrc3-2; Tue, 13 Oct 2015 10:15:15 +0200 (CEST) Received: from noc1.cksoft.de (noc1.cksoft.de [IPv6:2a01:170:1110:8001::53:1]) by m.cksoft.de (Postfix) with ESMTP id BD82463347; Tue, 13 Oct 2015 10:15:14 +0200 (CEST) Received: by noc1.cksoft.de (Postfix, from userid 1000) id C110B13BEC; Tue, 13 Oct 2015 10:16:46 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by noc1.cksoft.de (Postfix) with ESMTP id BABBB13B2E; Tue, 13 Oct 2015 10:16:46 +0200 (CEST) Date: Tue, 13 Oct 2015 10:16:46 +0200 (CEST) From: Christian Kratzer X-X-Sender: ck@noc1.cksoft.de Reply-To: Christian Kratzer To: Rick Macklem cc: freebsd-stable@freebsd.org, John Baldwin Subject: Re: smbfs crashes since approx. 10.1-RELEASE In-Reply-To: <173739656.33429352.1444704458926.JavaMail.zimbra@uoguelph.ca> Message-ID: References: <3563189.eDHDcCgW5L@ralph.baldwin.cx> <358885214.31305796.1444518367048.JavaMail.zimbra@uoguelph.ca> <2135054744.32546564.1444653156980.JavaMail.zimbra@uoguelph.ca> <173739656.33429352.1444704458926.JavaMail.zimbra@uoguelph.ca> User-Agent: Alpine 2.20 (BSF 67 2015-01-07) X-Spammer-Kill-Ratio: 75% MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2015 08:16:52 -0000 Hi Rick, On Mon, 12 Oct 2015, Rick Macklem wrote: > Well, you can try the attached one instead of the previous ones (ie. against stable). > It just delays destroying the mutexes until the iod thread is exiting. > > I can't quite see why the previous patches wouldn't fix it, but this one leaves > smb_iod_main() unchanged, so it is a simpler patch and doesn't affect semantics > except for a slight delay in destroying the mutexes. patch applied this morning against plain 10-stable with wittness enabled ... >> As it looks like that the race happens on unmount I could try putting a sleep >> 60 into the >> script that does the "mount && rsycn && umount" magic just before the umount. >> That would >> allow anything that it slow to go away to perhaps release the mutexes before >> the umount. >> > If it still crashes with this patch, it might be worth a try. I had a sleep 60 before the umount over night and it did not crash. Could have been to short a wait though. I have removed the sleep 60 in order to give your patch a good testing > Or, if this patch still crashes, you could just delete the 3 lines that the > patch moves, so the mutexes are never destroyed. This would result in a leak, > but it would tell us if destroying these mutexes is the problem. Good point. > Thanks for your willingness to test these, rick No problem. Thanks to you for wrapping your head around this. Greetings Christian -- Christian Kratzer CK Software GmbH Email: ck@cksoft.de Wildberger Weg 24/2 Phone: +49 7032 893 997 - 0 D-71126 Gaeufelden Fax: +49 7032 893 997 - 9 HRB 245288, Amtsgericht Stuttgart Mobile: +49 171 1947 843 Geschaeftsfuehrer: Christian Kratzer Web: http://www.cksoft.de/