From owner-cvs-src@FreeBSD.ORG Mon May 10 07:26:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0174016A4CF; Mon, 10 May 2004 07:26:21 -0700 (PDT) Received: from srv01.sparkit.no (srv01.sparkit.no [193.69.116.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id A581D43D4C; Mon, 10 May 2004 07:26:19 -0700 (PDT) (envelope-from eivind@FreeBSD.org) Received: from ws.nada ([193.69.114.88]) by srv01.sparkit.no (8.12.11/8.12.11) with ESMTP id i4AEQFCk007121; Mon, 10 May 2004 16:26:15 +0200 (CEST) (envelope-from eivind@FreeBSD.org) Received: from ws.nada (localhost [127.0.0.1]) by ws.nada (8.12.9/8.12.10) with ESMTP id i4AEO4xA017307; Mon, 10 May 2004 14:24:04 GMT (envelope-from eivind@ws.nada) Received: (from eivind@localhost) by ws.nada (8.12.9/8.12.10/Submit) id i4AEO4pZ017306; Mon, 10 May 2004 14:24:04 GMT (envelope-from eivind) Date: Mon, 10 May 2004 14:24:03 +0000 From: Eivind Eklund To: Maxime Henrion Message-ID: <20040510142403.GA17251@FreeBSD.org> References: <200405101150.i4ABoL9V065750@repoman.freebsd.org> <20040510115040.2BD4B16A53F@hub.freebsd.org> <20040510130612.GA14041@FreeBSD.org> <20040510131313.GG700@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040510131313.GG700@elvis.mu.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/led led.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 May 2004 14:26:21 -0000 On Mon, May 10, 2004 at 03:13:13PM +0200, Maxime Henrion wrote: > Eivind Eklund wrote: > > Not a big deal, but a minor style issue: > > > > On Mon, May 10, 2004 at 04:50:40AM -0700, Maxime Henrion wrote: > > > - Fix some style bugs while I'm here. > > > > [...] > > > > > -#endif /* _DEV_LED_H */ > > > +#endif > > > > Based in my presently installed /usr/include/sys, the style statistics > > for /usr/include/sys/*.h is as follows: > > > > #endif #endif /* _DEV_LED_H */ #endif /* !_DEV_LED_H */ > > 28 52 148 > > 12% 23% 65% > > > > The removal of /* _DEV_LED_H */ from the last #endif brings it from an > > uncommon style to an even less common style. > > Both styles are allowed by style(9) under different circumstances. If the > #ifdef'ed block is big, then you should add the /* FOO_H */ comment. If > it's not, you shouldn't put it, hence why I removed it. So this isn't a > matter of which style is used most :-). Given the frequencies involved, I think it would be better style to make all full-file-wrapping ifdefs (which is what I counted above) be consistant. There's only 12% that are really "off style", and eliminating this seems better than increasing it or keeping it consistent with #ifdef/#endif's inside files (WRT "long" or "short" ifdef's) NRN. Eivind.