From owner-freebsd-current@freebsd.org Sun Jul 31 09:29:20 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7AD66BA9091 for ; Sun, 31 Jul 2016 09:29:20 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 57E281643 for ; Sun, 31 Jul 2016 09:29:20 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 53BF8BA9090; Sun, 31 Jul 2016 09:29:20 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 50FF7BA908D for ; Sun, 31 Jul 2016 09:29:20 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C1C661641; Sun, 31 Jul 2016 09:29:19 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wm0-x241.google.com with SMTP id i5so21874021wmg.2; Sun, 31 Jul 2016 02:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=mFuS5HPOXNsETAw/Gih3v76/pxblVA6ApY0KAo8Cw9g=; b=AMfdNS5KL+H/HJLfyllSyMmEfPOsWqIE3vLygb4SzlGXEEq/CW8/LGkVmjCb5lWQmW xAMoxWeaNAOu2ZQeHy098ymUhnemcG127hW62yrMe3WeNUg1w4ajA71UzgsblxTkJ8kv NtwnWMjT0TLhjeHER4JoT3qBoY9dG6DAKrFXZC5Sc9qPMNB43LHfophlY2+44bq4Hzuy 2dBp9qRnahE4GPxpsCWsUS4NuVDBIS2sCJgLarOvR4IOHUoCn67eyigdsYZChHdS6KbP LrN+dg2twSnICeJDu90qPOWcTqv0rMqEGKpBikG8zzZAh8pN0alZI0n/1XZF6KSwFwRT WqjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=mFuS5HPOXNsETAw/Gih3v76/pxblVA6ApY0KAo8Cw9g=; b=AjpEIyy4y2cMQ5wfbKDv51uo7Z6u0Vlc0zJvE8gW8lW7o1XjS9qlGHP4NskHcy5DrR 2MDXar5d01v6B/K9SrSn4lRvW9NKgO3epeMoUyGlvKrg1BNHxSEK70FuP9d3g3AWcujI ZzBj5WU+awi2li81DuH3O6LsDK41+mAMwPxAQ61NC4eNX0R2YXHfZFUpnoDLOm88ihvq Mt97PDKqbLnGQ6Fw5gIuQ9ywJO/R1//yW0ETL07YvIn5H+EYooVOjkaBJA9IsT6IB7cC 4sHZJ6++3X028G1y5SNylU5FHr/M54eY4c5QVzh8/QJgiTIy/LPz3Qae2UQIIwLK0eFe sEyw== X-Gm-Message-State: AEkoouvx/weww+nhgZc2WvG9P2RKcIP9Z6qH9YscUQkOujX7c0BQ2Sxi+TdSmZA0SeIkhg== X-Received: by 10.194.23.39 with SMTP id j7mr46523578wjf.4.1469957357230; Sun, 31 Jul 2016 02:29:17 -0700 (PDT) Received: from ernst.home (p578E192D.dip0.t-ipconnect.de. [87.142.25.45]) by smtp.gmail.com with ESMTPSA id r13sm11347320wmf.12.2016.07.31.02.29.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Jul 2016 02:29:16 -0700 (PDT) Date: Sun, 31 Jul 2016 11:29:14 +0200 From: Gary Jennejohn To: John Baldwin Cc: current@freebsd.org Subject: Re: EARLY_AP_STARTUP hangs during boot Message-ID: <20160731112914.58bd9765@ernst.home> In-Reply-To: <8097239.52FCHCROUA@ralph.baldwin.cx> References: <20160516122242.39249a54@ernst.home> <2732687.Cf9hD9SkSs@ralph.baldwin.cx> <20160730094422.68e1b8db@ernst.home> <8097239.52FCHCROUA@ralph.baldwin.cx> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2016 09:29:20 -0000 On Sat, 30 Jul 2016 12:03:59 -0700 John Baldwin wrote: > On Saturday, July 30, 2016 09:44:22 AM Gary Jennejohn wrote: > > On Fri, 29 Jul 2016 13:17:42 -0700 > > John Baldwin wrote: > > > > > On Thursday, July 28, 2016 12:31:31 AM Gary Jennejohn wrote: > > > > Well, now I know that ULE is a prerequiste for EARLY_AP_STARTUP! I > > > > wasn't aware of that. I prefer BSD and that's the scheduler I did > > > > the first tests with. > > > > > > > > But with the ULE scheduler the system comes up all the way. > > > > > > > > It would be nice if the BSD scheduler could also be modified to > > > > work with EARLY_AP_STARTUP. > > > > > > I wasn't able to reproduce your hang with 4BSD, but I think I see a > > > possible problem. Try this: > > > > > > diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c > > > index 7de56b6..d53331a 100644 > > > --- a/sys/kern/sched_4bsd.c > > > +++ b/sys/kern/sched_4bsd.c > > > @@ -327,7 +327,6 @@ maybe_preempt(struct thread *td) > > > * - The current thread has a higher (numerically lower) or > > > * equivalent priority. Note that this prevents curthread from > > > * trying to preempt to itself. > > > - * - It is too early in the boot for context switches (cold is set). > > > * - The current thread has an inhibitor set or is in the process of > > > * exiting. In this case, the current thread is about to switch > > > * out anyways, so there's no point in preempting. If we did, > > > @@ -348,7 +347,7 @@ maybe_preempt(struct thread *td) > > > ("maybe_preempt: trying to run inhibited thread")); > > > pri = td->td_priority; > > > cpri = ctd->td_priority; > > > - if (panicstr != NULL || pri >= cpri || cold /* || dumping */ || > > > + if (panicstr != NULL || pri >= cpri /* || dumping */ || > > > TD_IS_INHIBITED(ctd)) > > > return (0); > > > #ifndef FULL_PREEMPTION > > > @@ -1127,7 +1126,7 @@ forward_wakeup(int cpunum) > > > if ((!forward_wakeup_enabled) || > > > (forward_wakeup_use_mask == 0 && forward_wakeup_use_loop == 0)) > > > return (0); > > > - if (!smp_started || cold || panicstr) > > > + if (!smp_started || panicstr) > > > return (0); > > > > > > forward_wakeups_requested++; > > > > > > > Thanks, but with this patch the kernel hangs in exactly the same > > place as before - after the HPET output. > > > > Maybe I'm missing some kernel option which ULE works around, or > > something like that. > > Hmm, ok. Please add KTR_RUNQ and KTR_SMP to the KTR masks, that is > 'options KTR_COMPILE=(KTR_PROC|KTR_RUNQ|KTR_SMP)' and > 'options KTR_MASK=(KTR_PROC|KTR_RUNQ|KTR_SMP)' > > Please also add this patch (on top of the previous patch): > > diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c > index 2973a23..bab2278 100644 > --- a/sys/kern/sched_4bsd.c > +++ b/sys/kern/sched_4bsd.c > @@ -1278,6 +1278,8 @@ sched_add(struct thread *td, int flags) > KASSERT(td->td_flags & TDF_INMEM, > ("sched_add: thread swapped out")); > > + CTR2(KTR_PROC, "sched_add: thread %d (%s)", td->td_tid, > + sched_tdname(td)); > KTR_STATE2(KTR_SCHED, "thread", sched_tdname(td), "runq add", > "prio:%d", td->td_priority, KTR_ATTR_LINKED, > sched_tdname(curthread)); > diff --git a/sys/x86/x86/cpu_machdep.c b/sys/x86/x86/cpu_machdep.c > index f07b97e..1f418f1 100644 > --- a/sys/x86/x86/cpu_machdep.c > +++ b/sys/x86/x86/cpu_machdep.c > @@ -440,6 +440,7 @@ cpu_idle_wakeup(int cpu) > return (0); > if (*state == STATE_MWAIT) > *state = STATE_RUNNING; > + CTR1(KTR_PROC, "cpu_idle_wakeup: wokeup CPU %d", cpu); > return (1); > } > > (I haven't tried compiling it, you might have to add the sys/ktr.h > header to cpu_machdep.c if it doesn't build.) > > Hopefully we will get some better trace messages before it hangs > with this added info. The root issue seems to be that 4BSD is > pinning thread0 to some other CPU (due to sched_bind that happens > inside of bus_bind_intr() when the HPET driver pins IRQs to CPUs) > and that other CPU isn't waking up to realize it needs to run thread0. > It compiled with no changes needed. Even though I set MAXCPU to a mere 2, the boot still hadn't completed after 90 minutes and I broke it off. I still have the kernel, so I can try it another time when I have less need for my FreeBSD box. -- Gary Jennejohn