From owner-freebsd-smp Sat Dec 16 10:47: 7 2000 From owner-freebsd-smp@FreeBSD.ORG Sat Dec 16 10:47:05 2000 Return-Path: Delivered-To: freebsd-smp@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id 4A3B337B402; Sat, 16 Dec 2000 10:47:05 -0800 (PST) Received: from foo.osd.bsdi.com (root@foo.osd.bsdi.com [204.216.28.137]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id eBGIknE60182; Sat, 16 Dec 2000 10:46:49 -0800 (PST) (envelope-from jhb@foo.osd.bsdi.com) Received: (from jhb@localhost) by foo.osd.bsdi.com (8.11.1/8.11.0) id eBGIjxi62529; Sat, 16 Dec 2000 10:45:59 -0800 (PST) (envelope-from jhb) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Sat, 16 Dec 2000 10:45:59 -0800 (PST) Organization: BSD, Inc. From: John Baldwin To: Robert Watson Subject: Re: cvs commit: src/sys/sys proc.h Cc: smp@FreeBSD.ORG Sender: jhb@foo.osd.bsdi.com Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On 16-Dec-00 Robert Watson wrote: > > BTW, I don't know if you've had a chance to look at individual process > locking in kern_proc.c yet, but if so then the sysctl code to retrieve > process info will need some of the same work during kproc_info extraction > (protecting pcred, etc). Also, p_can* will have to assume that the > process mutexes for p1 and p2 are both already held (so as to avoid > recursion issues), so callers of p_can (especially in procfs and > signalling code) will need to reflect that assumption. We should grep > through for any direct references to p_cred throughout the tree, and where > possible eliminate them by improving authorization abstractions (if I > missed any inter-process calls), and where not, make sure they're properly > protected and documented (get/set-uid calls, sysctl, etc). Hmm, ok. I think I've seen one direct p_cred reference that wasn't to pc_ucred so far in sys/compat/svr4. I'll have to look at p_can* in a little more detail. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message