From owner-freebsd-current@FreeBSD.ORG Thu Sep 22 06:47:03 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 238E916A41F; Thu, 22 Sep 2005 06:47:03 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd3mo1so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id B986843D45; Thu, 22 Sep 2005 06:47:02 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd3mr8so.prod.shaw.ca (pd3mr8so-qfe3.prod.shaw.ca [10.0.141.24]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IN7009ZOHIDTBC0@l-daemon>; Thu, 22 Sep 2005 00:47:01 -0600 (MDT) Received: from pn2ml7so.prod.shaw.ca ([10.0.121.151]) by pd3mr8so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IN7002OEHIDHK40@pd3mr8so.prod.shaw.ca>; Thu, 22 Sep 2005 00:47:01 -0600 (MDT) Received: from [192.168.0.60] (S0106006067227a4a.vc.shawcable.net [24.87.209.6]) by l-daemon (iPlanet Messaging Server 5.2 HotFix 1.18 (built Jul 28 2003)) with ESMTP id <0IN700C05HIDC2@l-daemon>; Thu, 22 Sep 2005 00:47:01 -0600 (MDT) Date: Wed, 21 Sep 2005 23:47:00 -0700 From: Colin Percival In-reply-to: <43325114.4090907@gneto.com> To: Martin Nilsson Message-id: <43325364.8090208@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Accept-Language: en-us, en X-Enigmail-Version: 0.92.0.0 References: <200509211550.27524.jkim@FreeBSD.org> <43325114.4090907@gneto.com> User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050920) Cc: freebsd-current@freebsd.org, Jung-uk Kim Subject: Re: [PATCH] AMD multicore detection X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2005 06:47:03 -0000 Martin Nilsson wrote: > Jung-uk Kim wrote: >> New patch is here: >> http://people.freebsd.org/~jkim/multicore.diff >> >> Please test and let me know. I don't have multicore CPU to test it >> for myself. :-( > > The below is on a Pentium D 820 (Dualcore). I don't like that the two > cores are reported as hyperthreading when the CPU does not support > hyperthreading (only the 840 EE does). If we ship 6.0 with HT disabled > I'm afraid that it will turn off one of the cores, right? It shouldn't. Dual-core processors claim to be hyperthreaded, but when I wrote the patch which disabled hyperthreading I added extra (and rather complicated) code to detect dual-core processors and *not* disable them. If I got it wrong, please let me know. :-) Colin Percival