From owner-freebsd-ports@FreeBSD.ORG Sat Jan 15 11:16:39 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1CAEF16A4CE; Sat, 15 Jan 2005 11:16:39 +0000 (GMT) Received: from niobe.ijs.si (mail.ijs.si [193.2.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2801A43D41; Sat, 15 Jan 2005 11:16:38 +0000 (GMT) (envelope-from dejan.lesjak@ijs.si) Received: from localhost (localhost.ijs.si [127.0.0.1]) by niobe.ijs.si (Postfix) with ESMTP id EC6F61DD461; Sat, 15 Jan 2005 12:16:36 +0100 (CET) Received: from niobe.ijs.si ([127.0.0.1]) by localhost (niobe.ijs.si [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 12884-16; Sat, 15 Jan 2005 12:16:35 +0100 (CET) Received: from metatron.ijs.si (metatron.ijs.si [193.2.4.152]) by niobe.ijs.si (Postfix) with ESMTP id EFC0A1DD46A; Sat, 15 Jan 2005 12:16:34 +0100 (CET) Received: from idefix.ijs.si (idefix.ijs.si [193.2.4.33]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by metatron.ijs.si (Postfix) with ESMTP id 8AC7D1C00738; Sat, 15 Jan 2005 12:16:34 +0100 (CET) From: Dejan Lesjak To: freebsd-x11@freebsd.org Date: Sat, 15 Jan 2005 12:16:33 +0100 User-Agent: KMail/1.7.2 References: <20050104092619.GA787@straylight.m.ringlet.net> <20050104093017.GA1048@straylight.m.ringlet.net> In-Reply-To: <20050104093017.GA1048@straylight.m.ringlet.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200501151216.33792.dejan.lesjak@ijs.si> X-Virus-Scanned: amavisd-new at ijs.si cc: x11@freebsd.org cc: Peter Pentchev cc: freebsd-ports@freebsd.org Subject: Re: [PATCH] X.org/XFree86 DEPENDS_TARGET X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jan 2005 11:16:39 -0000 On Tuesday 04 of January 2005 10:30, Peter Pentchev wrote: > On Tue, Jan 04, 2005 at 11:26:19AM +0200, Peter Pentchev wrote: > > Hi, > > > > Maybe I should have spoken up earlier, since I've been running with > > this little patch for pretty much a year now, but still, better late > > than never, I guess :) > > Whoops. I certainly meant to CC this to -ports. > > > Currently, both x11/xorg and x11/XFree86-4 redefine the DEPENDS_TARGET > > when a package is requested. What do y'all think about the following > > trivial patch that makes it only override DEPENDS_TARGET if it does not > > already contain a 'package' target? I always build all ports with a > > DEPENDS_TARGET='install package clean', which helps a lot, especially > > with the X.org/XFree86 metaports ;) [snip] > > -.if make(package) > > +.if make(package) && ${DEPENDS_TARGET:Mpackage} == "" This doesn't seem to work if DEPENDS_TARGET is not defined, the following line however does: .if make(package) && empty(${DEPENDS_TARGET:Mpackage}) Does this still work in your case as expected? Dejan