From owner-freebsd-ports-bugs@freebsd.org Tue Feb 4 03:54:49 2020 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 612B923AD7C for ; Tue, 4 Feb 2020 03:54:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48BW6d1zywz4bhP for ; Tue, 4 Feb 2020 03:54:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 424DC23AD7B; Tue, 4 Feb 2020 03:54:49 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4214623AD7A for ; Tue, 4 Feb 2020 03:54:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48BW6d12xqz4bhM for ; Tue, 4 Feb 2020 03:54:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1B148B9A4 for ; Tue, 4 Feb 2020 03:54:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0143smji006947 for ; Tue, 4 Feb 2020 03:54:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0143smtp006946 for ports-bugs@FreeBSD.org; Tue, 4 Feb 2020 03:54:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 243860] www/gitlab-ce rc.d script does not support rcvar subcommand Date: Tue, 04 Feb 2020 03:54:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: amendlik@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: mfechner@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Feb 2020 03:54:49 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243860 Bug ID: 243860 Summary: www/gitlab-ce rc.d script does not support rcvar subcommand Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: mfechner@FreeBSD.org Reporter: amendlik@gmail.com Assignee: mfechner@FreeBSD.org Flags: maintainer-feedback?(mfechner@FreeBSD.org) The rc.d script that ships with www/gitlab-ce does not support the rcvar subcommand, as in:=20 # service gitlab rcvar This causes a problem for configuration management tools (Chef, Puppet, Sal= t, Ansible, etc.) because they depend on the rcvar subcommand to be present to determine the variable name when enabling/disabling services. I believe the entire input handling section of the rc.d script can be repla= ced with a call to 'run_rc_command'. It provides support for start, stop, resta= rt, status, rcvar, and more. ### Finally the input handling. - -case $gitlab_enable in - [yY][eE][sS]) - case "$1" in - start|quietstart|faststart) - start_gitlab - ;; - stop|faststop) - stop_gitlab - ;; - restart) - restart_gitlab - ;; - reload|force-reload) - reload_gitlab - ;; - status) - print_status - exit $gitlab_status - ;; - *) - echo "Usage: service gitlab {start|quietstart|faststop|stop|restart|reload|onestart|onestop|onerestart|= onreload|status}" - exit 1 - ;; - esac - ;; - *) - case "$1" in - onestart) - start_gitlab - ;; - onestop) - stop_gitlab - ;; - onerestart) - restart_gitlab - ;; - onreload) - reload_gitlab - ;; - status) - print_status - exit $gitlab_status - ;; - *) - echo "Usage: service gitlab {start|quietstart|faststop|stop|restart|reload|onestart|onestop|onerestart|= onreload|status}" - exit 1 - ;; - esac -esac +run_rc_command "$1" --=20 You are receiving this mail because: You are the assignee for the bug.=