Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Jul 2023 17:28:41 GMT
From:      Navdeep Parhar <np@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 47b1fef6fb22 - main - ifconfig: Fix the display of capabilities in the netlink based code.
Message-ID:  <202307201728.36KHSf65004576@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by np:

URL: https://cgit.FreeBSD.org/src/commit/?id=47b1fef6fb2299e5d1d7878c412f1dbd3effbc3d

commit 47b1fef6fb2299e5d1d7878c412f1dbd3effbc3d
Author:     Navdeep Parhar <np@FreeBSD.org>
AuthorDate: 2023-07-20 01:05:12 +0000
Commit:     Navdeep Parhar <np@FreeBSD.org>
CommitDate: 2023-07-20 17:26:18 +0000

    ifconfig: Fix the display of capabilities in the netlink based code.
    
    The capabilities in if_capabilities2/if_capenable2 are reported in the
    second 32b and were not being displayed correctly.  v does not need to
    be advanced because v[i / 32] is the correct 32b value already.
    
    Sponsored by:   Chelsio Communications
    
    Reviewed by:    kib@
    Differential Revision:  https://reviews.freebsd.org/D41107
---
 sbin/ifconfig/ifconfig_netlink.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sbin/ifconfig/ifconfig_netlink.c b/sbin/ifconfig/ifconfig_netlink.c
index f09023c1477c..0f449b7aae44 100644
--- a/sbin/ifconfig/ifconfig_netlink.c
+++ b/sbin/ifconfig/ifconfig_netlink.c
@@ -89,8 +89,6 @@ print_bits(const char *btype, uint32_t *v, const int v_count,
 
 	for (int i = 0; i < v_count * 32; i++) {
 		bool is_set = v[i / 32] & (1 << (i % 32));
-		if (i == 31)
-			v++;
 		if (is_set) {
 			if (num++ == 0)
 				printf("<");



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202307201728.36KHSf65004576>