From owner-freebsd-bugs@FreeBSD.ORG Tue Mar 31 03:30:03 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C88D106564A for ; Tue, 31 Mar 2009 03:30:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2E2A68FC19 for ; Tue, 31 Mar 2009 03:30:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n2V3U33a081931 for ; Tue, 31 Mar 2009 03:30:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n2V3U3xv081928; Tue, 31 Mar 2009 03:30:03 GMT (envelope-from gnats) Resent-Date: Tue, 31 Mar 2009 03:30:03 GMT Resent-Message-Id: <200903310330.n2V3U3xv081928@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, soflare Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4F0C106566C for ; Tue, 31 Mar 2009 03:20:31 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id B2BDE8FC13 for ; Tue, 31 Mar 2009 03:20:31 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n2V3KVQl093010 for ; Tue, 31 Mar 2009 03:20:31 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n2V3KVM8093009; Tue, 31 Mar 2009 03:20:31 GMT (envelope-from nobody) Message-Id: <200903310320.n2V3KVM8093009@www.freebsd.org> Date: Tue, 31 Mar 2009 03:20:31 GMT From: soflare To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/133235: Process SIOCDLIFADDR command incorrectly in in_control() X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2009 03:30:03 -0000 >Number: 133235 >Category: kern >Synopsis: Process SIOCDLIFADDR command incorrectly in in_control() >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 31 03:30:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: soflare >Release: 7.0-RELEASE >Organization: >Environment: FreeBSD liangzy-fbsd7.home.net 7.1-RELEASE FreeBSD 7.1-RELEASE #12: Fri Mar 20 21:19:12 UTC 2009 root@liangzy-fbsd7.arraynetworks.com.cn:/usr/obj/usr/src/sys/SOLAR i386 >Description: Can't delete an alias by using SIOCDLIFADDR command. Always return EADDRNOTAVAIL. >How-To-Repeat: >Fix: Patch attached with submission follows: --- in.c 2009-03-20 21:09:46.000000000 +0000 +++ src/sys/netinet/in.c 2009-03-20 21:15:35.000000000 +0000 @@ -634,11 +634,13 @@ in_lifaddr_ioctl(struct socket *so, u_lo } TAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link) { - if (ifa->ifa_addr->sa_family != AF_INET6) + struct sockaddr_in *sa; + sa=(struct sockaddr_in *)ifa->ifa_addr; + if (ifa->ifa_addr->sa_family != AF_INET) continue; if (match.s_addr == 0) break; - candidate.s_addr = ((struct sockaddr_in *)&ifa->ifa_addr)->sin_addr.s_addr; + candidate.s_addr = sa->sin_addr.s_addr; candidate.s_addr &= mask.s_addr; if (candidate.s_addr == match.s_addr) break; >Release-Note: >Audit-Trail: >Unformatted: