Date: Tue, 4 Dec 2012 13:23:41 +0100 From: Gabor Pali <pgj@FreeBSD.org> To: "Jason E. Hale" <jhale@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r308217 - in head/devel/icmake: . files Message-ID: <CAHnG2Cx6rS9QgJk=YvmqtZxq4qTu2joTP_7vZu8XopZHQFb13g@mail.gmail.com> In-Reply-To: <1837268.Hp4WNQ0tny@mocha.verizon.net> References: <201212040913.qB49DUfk028183@svn.freebsd.org> <1837268.Hp4WNQ0tny@mocha.verizon.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Thank you for your caring comments. See may answers in-line below.
On Tue, Dec 4, 2012 at 12:45 PM, Jason E. Hale <jhale@freebsd.org> wrote:
> This commit added a property change to head that I don't think should be
> there:
> svk:merge 7042ac7c-f72f-e211-9f8d-6cf0491430cb:/svk/freebsd-ports-local:307972
Indeed. Nice catch! Fixed.
> COMMENT should drop leading indefinite article "An"
Done.
>> +MAKE_ENV= CC="${CC}" CFLAGS="${CFLAGS}"
>> +
>
> ^ These are already set in b.p.m.
Indeed, cruft removed.
>> - @${REINPLACE_CMD} -e 's|#!/bin/bash|#!${LOCALBASE}/bin/bash|' \
>> + @${REINPLACE_CMD} -I "" -e 's|#!/bin/bash|#!${LOCALBASE}/bin/bash|' \
>
> Wouldn't it be easier to just set REINPLACE_ARGS= -I "" ?
Yeah, fixed :-)
>> .if !defined(NOPORTDOCS)
>
> Should convert to ${PORT_OPTIONS:MDOCS}
Hrm, I did not find any authoritative guidance on this. Once I asked
bapt about this, and he told me that keeping NOPORTDOCS is okay, if I
recall correctly.
>> -WWW: http://icmake.sourceforge.net/
>> +WWW: http://icmake.sourceforge.net/
>>
> Why the change to tab? Single space is the standard.
Why not? :-) I use tabs after "WWW:" in pkg-descr for all of my
ports. Is this in the Porter's Handbook?
>> @comment $FreeBSD$
>
> ^ This isn't neccessary. Tools/scripts/psvn should be used to set the props
> correctly.
Yes, I know, but this is also kind of a habit that I maintain for my
ports. Does it cause any problems?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHnG2Cx6rS9QgJk=YvmqtZxq4qTu2joTP_7vZu8XopZHQFb13g>