From owner-freebsd-hackers@FreeBSD.ORG  Wed May  1 22:13:44 2013
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id A65AE229;
 Wed,  1 May 2013 22:13:44 +0000 (UTC) (envelope-from bright@mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
 by mx1.freebsd.org (Postfix) with ESMTP id 96E4D1609;
 Wed,  1 May 2013 22:13:44 +0000 (UTC)
Received: from Alfreds-MacBook-Pro-9.local
 (c-67-180-208-218.hsd1.ca.comcast.net [67.180.208.218])
 by elvis.mu.org (Postfix) with ESMTPSA id 9D0AE1A3CBA;
 Wed,  1 May 2013 15:13:41 -0700 (PDT)
Message-ID: <51819386.6010107@mu.org>
Date: Wed, 01 May 2013 15:13:26 -0700
From: Alfred Perlstein <bright@mu.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:17.0) Gecko/20130328 Thunderbird/17.0.5
MIME-Version: 1.0
To: Brooks Davis <brooks@freebsd.org>
Subject: Re: potential future proofing fix for aicasm build.
References: <51814686.2060805@ixsystems.com>
 <20130501213810.GB45806@lor.one-eyed-alien.net>
In-Reply-To: <20130501213810.GB45806@lor.one-eyed-alien.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: hackers@freebsd.org
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 May 2013 22:13:44 -0000

On 5/1/13 2:38 PM, Brooks Davis wrote:
> On Wed, May 01, 2013 at 09:44:54AM -0700, Alfred Perlstein wrote:
>> Hey folks,
>>
>> I took a shot at fixing this issue with building aicasm as part of
>> "buildkernel" of an older 9.0 src on a machine running HEAD.
>>
>> aicasm.o: In function `__getCurrentRuneLocale': >
>> /usr/include/runetype.h:96: undefined reference to `_ThreadRuneLocale'
>>
>> The issue seems to be two-fold:
>>
>> 1) Paths are not fully set to pick up the bootstrap tools needed to build.
>> 2) include files use the host's instead of the build trees.
>>
>> The first problem is fixed by changing setting of PATH from
>> "${BPATH}:${PATH}" to ${TMPPATH}.
>>
>> The second is fixed by using -nostdinc and setting strict include paths
>> using -I directives to the compiler:
>>
>> CFLAGS="-nostdinc -I${WORLDTMP}/usr/include -I. -I${KERNSRCDIR}/dev/aic7xxx/aicasm"
> This seems basically ok.
>
>> Can I get review on this patch?
> The line wrapping bugs should have been fixed before posting, but it
> otherwise looks fine.
>
> I do wonder why we don't just install aicasm in the base and bootstrap
> it in the unlikely event that it changes in an important way.  A quick
> scan of svn log suggests that gibbs fixed a bug in mid-2010 and the last
> non-build system or portability change was circa 2003 so I don't think
> we'd break old-style kernel builds at a rate worth worrying about.

It looks sort of like a shortcut was taken so that changes to the tool 
can be picked up by a kernel compile instead of needing another step.  
That was probably convenient at the time, but now is somewhat of a problem.

If I have time I will see about moving it to base.

Thank you for the review.  I will fix the white space and give make 
universe a whirl now.

-Alfred