From owner-svn-src-head@freebsd.org Wed Mar 21 15:12:35 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40FEAF4BF5D; Wed, 21 Mar 2018 15:12:35 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-lf0-f45.google.com (mail-lf0-f45.google.com [209.85.215.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A477F74B7A; Wed, 21 Mar 2018 15:12:34 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-lf0-f45.google.com with SMTP id z143-v6so8402389lff.3; Wed, 21 Mar 2018 08:12:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TVc41fw9FwamqmjlYZ8ICQCLB2Mo6hg4lKRhJgpxTgg=; b=TQ98IvoN35nVpOKqm3n3dVgBT5BdDMRfwKDAcae/oizObbaqTnUcOqJFkkhrlrSNEZ fwIP/KlzDF+p7QK+noQEW1hlSYAq8lccawBGuoZ/3gvQkLI8svuaN0gJ+pmBOs8ZjIe8 58eExXQNtRCg2vRV/7XbNE2+2re0KXLmM+OKYfdvzjCMz70OtL3QW7pddqH/sD010xE0 5ezWv8+Cqd8F5J/egpHkA9SSprGrwKOhzCFJgyyjd+GXbdJ6MDkG8H2eRXkvlNOA/Z+0 Wd+EWWLFAKOLQ5jMrgpS0wKPMd5ZQTGF9jtnKDmBIAcpZlUYoxSnmwVimayxP6Xv9+TR 8dQQ== X-Gm-Message-State: AElRT7G6tI596/U4IfFwn1FqmCe5pFjxugJubTo981NloPD2fg7ozgFb 84xq+yYdlosONTTHWf09iKgkzaOC X-Google-Smtp-Source: AG47ELvQe5Rolo+4vJPKf1yetzLnrgZQoFC+o1OKrRNTfxnS2rPFAeh/07AgyDsR6SMAo7dfydlNHw== X-Received: by 2002:a19:4acc:: with SMTP id x195-v6mr14756270lfa.46.1521645146488; Wed, 21 Mar 2018 08:12:26 -0700 (PDT) Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com. [209.85.215.53]) by smtp.gmail.com with ESMTPSA id j25sm338249lji.94.2018.03.21.08.12.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Mar 2018 08:12:26 -0700 (PDT) Received: by mail-lf0-f53.google.com with SMTP id a22-v6so8388533lfg.9; Wed, 21 Mar 2018 08:12:26 -0700 (PDT) X-Received: by 10.46.87.72 with SMTP id r8mr14273870ljd.93.1521645146155; Wed, 21 Mar 2018 08:12:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.129.90 with HTTP; Wed, 21 Mar 2018 08:12:05 -0700 (PDT) In-Reply-To: <401EA542-5E2B-4342-B098-7C8D78FAD721@freebsd.org> References: <201803202026.w2KKQOP2036471@repo.freebsd.org> <401EA542-5E2B-4342-B098-7C8D78FAD721@freebsd.org> From: Kyle Evans Date: Wed, 21 Mar 2018 10:12:05 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r331259 - head/stand/lua To: Devin Teske Cc: Kyle Evans , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 15:12:35 -0000 On Tue, Mar 20, 2018 at 6:04 PM, Devin Teske wrote: > > Minor nit ... > > While resetf is unlikely to be mistaken for anything other than "reset foreground", ... > > "resetb" could easily be mistaken for "reset bold". > > I would like to suggest, in tradition, that resetf/resetb be renamed to resetfg/resetbg > > You know... should you want to add a "resetb" later that actually resets bold (e.g., if you have to use CSI 22m in more than one place). > -- > Devin This set of functions has been renamed in r331304. The choice of 'f' and 'b' always kind of bothered me, but not enough to actually fix it until someone else complained about it. =)