Date: Sat, 31 Dec 2005 14:50:27 +0000 From: Darren Reed <darrenr@hub.freebsd.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net bpf_filter.c Message-ID: <20051231145027.GB38051@hub.freebsd.org> In-Reply-To: <200512080005.jB8053R4099474@repoman.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Thu, Dec 08, 2005 at 12:05:03AM +0000, Jung-uk Kim wrote: > jkim 2005-12-08 00:05:03 UTC > > FreeBSD src repository > > Modified files: > sys/net bpf_filter.c > Log: > Do not accept an empty bpf program. You need to make one of two follow up changes here: 1) explicitly allow 0-length programs 2) fix bpf_filter (see the first check and its comments for "return -1") Personally I'd prefer to see (1) because it allows you to "set" a BPF program and measure the performance impact of the BPF code on networking without having to worry about the cost of executing the BPF program itself. Darrenhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051231145027.GB38051>