From owner-freebsd-current@FreeBSD.ORG Mon Oct 21 03:53:59 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0C6C59F7 for ; Mon, 21 Oct 2013 03:53:59 +0000 (UTC) (envelope-from sean_bruno@yahoo.com) Received: from nm21-vm6.bullet.mail.ne1.yahoo.com (nm21-vm6.bullet.mail.ne1.yahoo.com [98.138.91.114]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C256F26E3 for ; Mon, 21 Oct 2013 03:53:58 +0000 (UTC) Received: from [98.138.90.50] by nm21.bullet.mail.ne1.yahoo.com with NNFMP; 21 Oct 2013 03:50:53 -0000 Received: from [98.138.226.126] by tm3.bullet.mail.ne1.yahoo.com with NNFMP; 21 Oct 2013 03:50:53 -0000 Received: from [127.0.0.1] by smtp205.mail.ne1.yahoo.com with NNFMP; 21 Oct 2013 03:50:53 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1382327453; bh=ikSPjuehesR2IW+zLTsiliRkQOVO8RcWuuB75s8RUoA=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Subject:From:Reply-To:To:Content-Type:Date:Message-ID:Mime-Version:X-Mailer; b=b42uR3L2z5M3/LlRWeOkglL+zncgJYC8EKAuqYUkUjniIQQUkEt5zAaTiuHDVC3V67Yf1ynxaw8rdViHzNw182Xz3MiuAvAhPa9Cjvge1NiTMx8BzCPkKUqIgrEOwalMTqOYr2mSPkNKngPU8ZJpjDywjequk9h0EzlUGqhab0k= X-Yahoo-Newman-Id: 770374.41612.bm@smtp205.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: cEjov6EVM1nl5_X8G0qykWIrOBYh3s1oSJeF1emo1Qm2h7f DcuapggquNPRoJm23DzXMVRkDRG9hUokXvfKevyotZavfSRj8opa8iHX8CfF DmD.p1XUFMAsqsL9tiS.Zjrpw53S3kdma.v_yBnYuru1w6xfbRHHgI9K70Pw tJgP_18eMdng_ED5jMXjtFbQuZ2rCgwMDpbRZ9V_6zVtfHI8neMPBQwNEby0 yAEy7JUOY7fKRQgXyCJOMQ.jCiH316Ucl.xv2UmC2JD7zjbkNPxECJasatDN I4pjZAglE9urfQZJo2zPc5lUrDyzRGBr0rEdcMNEMHJsogN1Rn_Y883GN1ZA 6cfEVzFo3dubzoHAHilk8RZgYjg8Hn78YmvxV0Auzxu5VtBbnWjirMsrY.ph pq0Zradc4s2zqpXRk1GJ5P_yM3rscBxi5HJkWUuHNzXVAeRNI4x_v7QsUGoH G.yiFzURvKh2Vz1bDW6dDWRCumBM.ccR9rscKIi3etTJZEaEBqGmFPV6ziBQ Vw.Q85aoqFAHQnVXEOxZiN6FqpGYzzG0OkNzYoLFV4yU8TDBaz943t4aJKUs Y37ycyz34ICBIM3irS0TwWyq33fmokfpF_He49o_SB7Gw.aKKsqWByEYUnu4 Osto- X-Yahoo-SMTP: u5BKR6OswBC_iZJVfGRoMkTIpc8pEA4- X-Rocket-Received: from [192.168.100.108] (sean_bruno@63.138.121.126 with ) by smtp205.mail.ne1.yahoo.com with SMTP; 20 Oct 2013 20:50:53 -0700 PDT Subject: gperf/src/options.cc -- quiesce clang warnings -Wlogical-op-parentheses From: Sean Bruno To: "freebsd-current@freebsd.org" Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-cv+ODW3SEIWT6pW48P+B" Date: Sun, 20 Oct 2013 23:50:52 -0400 Message-ID: <1382327452.2610.5.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: sbruno@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Oct 2013 03:53:59 -0000 --=-cv+ODW3SEIWT6pW48P+B Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable gperf has some clang warnings that seem to be harmless, but annoying regarding some of the logical operations around detecting ascii chars: c++ -O2 -pipe -I/usr/obj/usr/src/tmp/legacy/usr/include -Wno-c ++11-extensions -I/usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/lib -I/usr/src/gnu/usr.bin/g perf -c /usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/options.cc /usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/options.cc:284:27: warning: '&&' within '||' [-Wlogical-op-parentheses] if (*arg >=3D 'A' && *arg <=3D 'Z' || *arg >=3D 'a' && *arg <=3D = 'z') ~~~~~~~~~~~~^~~~~~~~~~~~~~ ~~ I propose the following change: Index: options.cc =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- options.cc (revision 256712) +++ options.cc (working copy) @@ -281,7 +281,7 @@ { putchar (*arg); arg++; - if (*arg >=3D 'A' && *arg <=3D 'Z' || *arg >=3D 'a' && *arg <=3D= 'z') + if ( (*arg >=3D 'A' && *arg <=3D 'Z') || (*arg >=3D 'a' && *arg = <=3D 'z') ) { putchar (*arg); arg++; @@ -293,7 +293,9 @@ putchar (*arg); arg++; } - while (*arg >=3D 'A' && *arg <=3D 'Z' || *arg >=3D 'a' && *a= rg <=3D 'z' || *arg =3D=3D '-'); + while ( (*arg >=3D 'A' && *arg <=3D 'Z') || + (*arg >=3D 'a' && *arg <=3D 'z') || + (*arg =3D=3D '-') ); if (*arg =3D=3D '=3D') { putchar (*arg); --=-cv+ODW3SEIWT6pW48P+B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQEcBAABAgAGBQJSZKScAAoJEBkJRdwI6BaHEUQH/ipu5CM3zVkaZ4G+gYn3aavo K4aa7iyKNU1LVlEF2tOyci7vUufKeAAmDqyo1YWNrKVB83/rXs3OEhIFErogLUVW HgpsSzuFZmzy+CX07nI3BtvzDpkmxefUNvlMgvS9Qjbue0gzD3Fkfnqj2oW3jkIh HkEY41firfx7lvN8DzhRl03eWfoz//Tq4yUB4cg3TDsL/rVbNKQC+TMbNzn1hWks W/653GXNNLgs7Le5djL8crNAQJCgs2t/zDskI5HFMSYuoFxcoH3Izi7cx3McY4WI 9XyzZ9Ytj4ghlI+y2A7sAFYoxRy5N8GeUyEUE/Ks1FLxPRzNcs5n4JoggwrdTR8= =xCRV -----END PGP SIGNATURE----- --=-cv+ODW3SEIWT6pW48P+B--