Date: Thu, 27 Sep 2012 13:18:10 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Edward Tomasz Napierala <trasz@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240993 - head/sys/cam/ctl Message-ID: <20120927131810.GA54552@FreeBSD.org> In-Reply-To: <201209271051.q8RApcmq002950@svn.freebsd.org> References: <201209271051.q8RApcmq002950@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 27, 2012 at 10:51:38AM +0000, Edward Tomasz Napierala wrote: > New Revision: 240993 > URL: http://svn.freebsd.org/changeset/base/240993 > > Log: > Remove useless NULL checks after M_WAITOK allocations. > > @@ -1520,12 +1520,6 @@ ctl_ioctl_do_datamove(struct ctl_scsiio > > ext_sglist = (struct ctl_sg_entry *)malloc(ext_sglen, M_CTL, M_WAITOK); You could have also removed bogus casting of void * returned by malloc(). Perhaps it makes sense to clean up more than just this file thought. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120927131810.GA54552>