From owner-cvs-all  Tue Jul  9  9: 4:49 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 86DFE37B405; Tue,  9 Jul 2002 09:04:45 -0700 (PDT)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A939943E52; Tue,  9 Jul 2002 09:04:44 -0700 (PDT)
	(envelope-from dl-freebsd@catspoiler.org)
Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.12.5/8.12.5) with ESMTP id g69G4Xwr004252;
	Tue, 9 Jul 2002 09:04:38 -0700 (PDT)
	(envelope-from dl-freebsd@catspoiler.org)
Message-Id: <200207091604.g69G4Xwr004252@gw.catspoiler.org>
Date: Tue, 9 Jul 2002 09:04:33 -0700 (PDT)
From: Don Lewis <dl-freebsd@catspoiler.org>
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c 
To: silby@silby.com
Cc: peter@wemm.org, luigi@FreeBSD.org, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
In-Reply-To: <20020708171914.C19349-100000@patrocles.silby.com>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On  8 Jul, Mike Silbersack wrote:

> Hm, I see the problem.  The fxp driver releases transmit mbufs in both
> fxp_intr _and_ in fxp_tick.  fxp_tick needs code such as:
> 
> 
>         for (txp = sc->cbl_first; sc->tx_queued &&
>             (txp->cb_status & FXP_CB_STATUS_C) != 0;
>             txp = txp->next) {
>                 if (txp->mb_head != NULL) {
>                         m_freem(txp->mb_head);
>                         txp->mb_head = NULL;
>                 }
>                 sc->tx_queued--;
>         }
>         sc->cbl_first = txp;
> +	if (sc->tx_queued == 0)
> +		ifp->if_timer = 0;
> 
> Give that a whirl and see if it solves the problem.

So far nothing evil has happened ;-)


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message