From owner-cvs-src@FreeBSD.ORG  Fri Dec 15 00:26:00 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 24D3316A415;
	Fri, 15 Dec 2006 00:26:00 +0000 (UTC) (envelope-from jdp@polstra.com)
Received: from blake.polstra.com (blake.polstra.com [64.81.189.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 89D0B43F4F;
	Fri, 15 Dec 2006 00:13:26 +0000 (GMT) (envelope-from jdp@polstra.com)
Received: from strings.polstra.com (strings.polstra.com [64.81.189.67])
	by blake.polstra.com (8.13.8/8.13.8) with ESMTP id kBF0F0r7036713;
	Thu, 14 Dec 2006 16:15:00 -0800 (PST) (envelope-from jdp@polstra.com)
Message-ID: <XFMail.20061214161500.jdp@polstra.com>
X-Mailer: XFMail 1.5.5 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <09BFF2FA5EAB4A45B6655E151BBDD903029CEDDE@NT-IRVA-0750.brcm.ad.broadcom.com>
Date: Thu, 14 Dec 2006 16:15:00 -0800 (PST)
From: John Polstra <jdp@polstra.com>
To: David Christensen <davidch@broadcom.com>
Cc: John Polstra <jdp@FreeBSD.org>, cvs-src@FreeBSD.org,
	src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: RE: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Dec 2006 00:26:00 -0000

On 15-Dec-2006 David Christensen wrote:
> MSI capabilities registers are present on virtually all "bge"
> controllers but many of the "older" controllers don't correctly support
> MSI due to a chip errata that prevents MSI interrupts from actually
> being disabled during an ISR.  Check the Linux code for the test used in
> tg3_open() which determines which controllers can actually use MSI
> correctly.  
> 
> Even with the bug the older controllers will appear to work correctly on
> a heavily loaded system for short periods of time (sometimes even days)
> but they will eventually fail.

Thanks for the heads up, Dave.  Scott Long also cautioned me about
this.  I'll disable the MSI support in the driver until I have time
to add the necessary checks.

John