From owner-cvs-sys Thu Jan 29 09:07:18 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA07226 for cvs-sys-outgoing; Thu, 29 Jan 1998 09:07:18 -0800 (PST) (envelope-from owner-cvs-sys) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA07220; Thu, 29 Jan 1998 09:07:07 -0800 (PST) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id EAA04615; Fri, 30 Jan 1998 04:00:36 +1100 Date: Fri, 30 Jan 1998 04:00:36 +1100 From: Bruce Evans Message-Id: <199801291700.EAA04615@godzilla.zeta.org.au> To: bde@zeta.org.au, toor@dyson.iquest.net Subject: Re: cvs commit: src/sys/i386/isa wfd.c Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, mike@smith.net.au Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >I don't know if the discussions between Justin and I were public or private, >but I have admitted that the addition of d_maxio as a single scalar was >inadequate. If the driver writers start using it, I'll be glad to do the >port to change things to a function interface when time has come. The thing >that is stopping me from doing it correctly right now is a severe time >constraint. If someone wants to do the d_maxio correctly right now, I >say go for it!!! :-). The changes aren't complex or substantial, but will >require more thought than I have put into it. I didn't see the discussion. I think a function call bdevswp->d_maxio() would be efficient enough. You copy the value the vnode on open and always access it from there. At least if the vnode remains bloated with v_maxio. There should also be a cdevsw function to give the "best" i/o size. Bruce