From owner-freebsd-current@FreeBSD.ORG Wed Nov 18 20:06:13 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68FEC106568F; Wed, 18 Nov 2009 20:06:13 +0000 (UTC) (envelope-from artemb@gmail.com) Received: from mail-iw0-f190.google.com (mail-iw0-f190.google.com [209.85.223.190]) by mx1.freebsd.org (Postfix) with ESMTP id 1326C8FC08; Wed, 18 Nov 2009 20:06:12 +0000 (UTC) Received: by iwn28 with SMTP id 28so1160070iwn.3 for ; Wed, 18 Nov 2009 12:06:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=Eo4maJ+AIJRlwdJF1Z2L226gpZWkLfcrJqw1tABdd5U=; b=n3G726MWusmSGcL+47tmQ7wEzuqlB6B8Dsyci9blIr1nrjTrPK3z+b+YoFfKC03Sfu zQC5g6lLEru8SvJDNEDL4vnnKyn6k3LOcxK0X+WiOrGcy0/dw90O2iqUH5NH4kFmt1+Q qADr07i0i9YzaVFlB5p8Ffgu/LIFDkKvJZl6o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=PNurvBa1vFwUfpKPvEOcX/bv39PKg/LcKhZdMMlbGcSFTjmR+4pU7SrXjd5IreNyQe QSwNOO3jycoTU6fIVhl4YQXXwxmTRbgRX0YNOrdUd0zydHKTIS1CU8Yl4vCaGZ9FtpPI aSDHnxmyHCXFVob6NkO+f2sm8WPGXSewKkbvo= MIME-Version: 1.0 Sender: artemb@gmail.com Received: by 10.231.157.131 with SMTP id b3mr2592118ibx.19.1258574772303; Wed, 18 Nov 2009 12:06:12 -0800 (PST) In-Reply-To: <20091119021440.560884b2.nork@FreeBSD.org> References: <20091119004651.7432a6e4.nork@FreeBSD.org> <4B042304.8060807@FreeBSD.org> <20091119021440.560884b2.nork@FreeBSD.org> Date: Wed, 18 Nov 2009 12:06:12 -0800 X-Google-Sender-Auth: 97d7cf09ea154b93 Message-ID: From: Artem Belevich To: Norikatsu Shigemura , Alexander Motin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org Subject: Re: How do I use NCQ of Intel X25-E(SSD) on ahci(4)? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Nov 2009 20:06:13 -0000 > --- sys/dev/ahci/ahci.c.orig =A0 =A02009-11-17 22:25:07.474418000 +0900 > +++ sys/dev/ahci/ahci.c 2009-11-19 02:00:22.193688908 +0900 > @@ -779,7 +779,7 @@ > =A0 =A0 =A0 =A0ch->caps =3D ctlr->caps; > =A0 =A0 =A0 =A0ch->caps2 =3D ctlr->caps2; > =A0 =A0 =A0 =A0ch->quirks =3D ctlr->quirks; > - =A0 =A0 =A0 ch->numslots =3D ((ch->caps & AHCI_CAP_NCS) >> AHCI_CAP_NCS= _SHIFT) + 1, > + =A0 =A0 =A0 ch->numslots =3D min(31, ((ch->caps & AHCI_CAP_NCS) >> AHCI= _CAP_NCS_SHIFT) + 1), > =A0 =A0 =A0 =A0mtx_init(&ch->mtx, "AHCI channel lock", NULL, MTX_DEF); > =A0 =A0 =A0 =A0resource_int_value(device_get_name(dev), > =A0 =A0 =A0 =A0 =A0 =A0device_get_unit(dev), "pm_level", &ch->pm_level); The comma at the end of the "ch->numslots =3D ..." line looks suspicious. Shouldn't it be ';' ? --Artem