From owner-dev-commits-ports-all@freebsd.org Tue Apr 20 05:05:15 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B8BE95E3FD6 for ; Tue, 20 Apr 2021 05:05:15 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FPWpL4YFDz3mTs for ; Tue, 20 Apr 2021 05:05:14 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: by mail-yb1-xb31.google.com with SMTP id g38so41512594ybi.12 for ; Mon, 19 Apr 2021 22:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lpAgNcnYGpDdhtfuAYiEnC+deohewPY7laItz1pNinE=; b=BUTF1/DwNzEMbHNIjZstXHy9GXFosWAGk9/kRSDAaxn9G4cYdkfmeew1fFz7mZNzso GEMdfXhVMQp9f99sihBFXcm+H7rCAC7tH+vJDBhcg48TQinE2ZtyAhlCYZ8oEhkR4CKb WuaDAaVOBu2Lzgm+mHEL1xqoyNrvzPzUlYzGM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lpAgNcnYGpDdhtfuAYiEnC+deohewPY7laItz1pNinE=; b=glgXRKUvUCv8rLs8kylgmPkmu6Vi1cHW9NhCDu5QDqmTWPrlcFUhU07PiOdRShenlV A5HwbVfx+e1Iao310yn61BIIjMyB6Fx28l1ESzDY26zmGpXQ3D30bo/0J3POH+D9xdIf XjdiEHxqjdKKZKp/JgjU3ey/sKY/nzLkfWuDVs4id3AAu2o6OSEUJzp5mkcO6isIL+QH asZSpHDFWELy0rnquD7f2JTadV/l6/k/4dwl6hEZjnlMw3otrJJKHL6YidJCT4iWjLkC 2fy7LNwjIgqW8oKg/DlnWWlocsDjHfgSKUeH1GvV6568j8NwK66ZaLdsaNRz4IfKyb3L o9IA== X-Gm-Message-State: AOAM533lyK9PE8fOlMD+BAeA8DQlshe29TMBiO/sx2A1BeuaDt6vlj5C vGr0GTuozPX3MSRYp+nogiAYG0YpzLRGcSvWL8v4Qw== X-Google-Smtp-Source: ABdhPJyMA/rpJ9hlSojRWYL97+uq1sxTrqDC28zmgWMYgNvoUFXhZZfBNDnxI/iNdd/kUPeIRl6jrKKsP8mPqm9aLp4= X-Received: by 2002:a25:e64c:: with SMTP id d73mr22575256ybh.391.1618895112966; Mon, 19 Apr 2021 22:05:12 -0700 (PDT) MIME-Version: 1.0 References: <202104192213.13JMDlRd039737@gitrepo.freebsd.org> <59a11a3f-3a47-176b-a566-a154709a4a69@FreeBSD.org> <202104200324.13K3OOwj010751@slippy.cwsent.com> In-Reply-To: <202104200324.13K3OOwj010751@slippy.cwsent.com> From: Kevin Bowling Date: Mon, 19 Apr 2021 22:05:01 -0700 Message-ID: Subject: Re: git: d3ba089a5212 - main - Update to version 2.2.13. To: Cy Schubert Cc: Pedro Giffuni , Dmitry Sivachenko , Yuri , ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4FPWpL4YFDz3mTs X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none (invalid DKIM record) header.d=kev009.com header.s=google header.b=BUTF1/Dw; dmarc=none; spf=pass (mx1.freebsd.org: domain of kevin.bowling@kev009.com designates 2607:f8b0:4864:20::b31 as permitted sender) smtp.mailfrom=kevin.bowling@kev009.com X-Spamd-Result: default: False [-1.30 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RBL_SENDERSCORE_FAIL(0.00)[2607:f8b0:4864:20::b31:server fail]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-ports-all@freebsd.org]; DMARC_NA(0.00)[kev009.com]; NEURAL_SPAM_SHORT(1.00)[1.000]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::b31:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[kev009.com:~]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::b31:from]; R_DKIM_PERMFAIL(0.00)[kev009.com:s=google]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::b31:from]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-ports-all]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2021 05:05:15 -0000 I'd like to see something for "Change URL:" or "Change Log:" too, currently some people add this but there seems to be no consistency. Since there isn't a common standard, I usually add it in the commit body as text so as not to imply structure someone might rely on in scripts, web UIs, etc... "changes //:url/" On Mon, Apr 19, 2021 at 8:24 PM Cy Schubert wrote: > > In message <59a11a3f-3a47-176b-a566-a154709a4a69@FreeBSD.org>, Pedro Giffuni wr > ites: > > On 19/04/2021 17:24, Dmitry Sivachenko wrote: > > > > > >> On 20 Apr 2021, at 01:17, Yuri wrote: > > >> > > >> On 4/19/21 3:13 PM, Dmitry Sivachenko wrote: > > >>> Update to version 2.2.13. > > >> > > >> Why didn't you mention in the commit message what port was updated? > > >> net/haproxy is one of thousands of ports and having a message like this do > > esn't help to understand what the change is. > > >> > > > Hello, > > > > > > what do you mean 'what port was updated'? It is clean from the commit log > > that it is net/haproxy that was updated, only two files changed: > > > Update to version 2.2.13. > > > > It is not a all "clean" if you do: > > > > git log --oneline > > This is a systemic problem that probably needs to be addressed sooner than later. > An aid like a .gitmessage might help. To help me remember I used this: > > # component (like category/port or bin/cat): Title line goes here > > # A paragraph or more to discuss the change. > > PR: > Submitted by: > Reported by: > Reviewed by: > Approved by: > Obtained from: > MFC after: > MFH: > Relnotes: > Security: > Sponsored by: > Differential Revision: > #--This line, and those below, will be ignored-- > # Description of fields to fill in above: 76 columns --| > # PR: If and which Problem Report is related. > # Submitted by: If someone else sent in the change. > # Reported by: If someone else reported the issue. > # Reviewed by: If someone else reviewed your modification. > # Tested by: If someone else tested the change. > # Approved by: If you needed approval for this commit. > # Obtained from: If the change is from a third party. > # MFC after: N [day[s]|week[s]|month[s]]. Request a reminder email. > # MFH: Ports tree branch name. Request approval for merge. > # Relnotes: Set to 'yes' for mention in release notes. > # Security: Vulnerability reference (one per line) or description. > # Sponsored by: If the change was sponsored by an organization. > # Differential Revision: https://reviews.freebsd.org/D### (*full* phabric URL needed). > # Empty fields above will be automatically removed. > > > Replacing the first two comments with a title line and a short paragraph, filling in the fields as needed, discarding the rest. > > This, https://chris.beams.io/posts/git-commit/, is a good read. > > Old habits die hard. Someone reached out to me in January but the .gitmessage template helped me a lot. Unlearning old habits is harder than learning new ones. > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > The need of the many outweighs the greed of the few. >