Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Mar 2017 22:35:13 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 217993] net/samba44 fails to build with new Uses/samba.mk
Message-ID:  <bug-217993-13-6OCVmuwwr8@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-217993-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-217993-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217993

--- Comment #3 from dewayne@heuristicsystems.com.au ---
(In reply to Antoine Brodin from comment #1)
Thank-you for looking into this.  With the exception of the bind9_11 line in
pkg-plist, we're very similar.  Perhaps as an aid, I've highlighted (with an
asterisk) the differences between a virgin build, where __MAKE_CONF=3D/dev/=
null
removes the influence of /etc/make.conf and my custom build.  There are NO
options files, as these are entirely controlled via etc/make.conf

# make __MAKE_CONF=3D/dev/null -C /usr/ports/net/samba44 showconfig | grep =
=3Don
     ACL_SUPPORT=3Don: File system ACL support
     ADS=3Don: Active Directory client support
     AD_DC=3Don: Active Directory Domain Controller support
  *  DEBUG=3Don: Build with debugging support
  *  DNSUPDATE=3Don: Dynamic DNS update (require ADS)
     DOCS=3Don: Build and/or install documentation
     FAM=3Don: File Alteration Monitor support
     LDAP=3Don: LDAP client support
     PTHREADPOOL=3Don: Pthread pool
  *  QUOTAS=3Don: Disk quota support
     SYSLOG=3Don: Syslog logging support
     UTMP=3Don: UTMP accounting support

What we are using:
# make -C /usr/ports/net/samba44 -DUSE_K8 showconfig | grep =3Don
     ACL_SUPPORT=3Don: File system ACL support
     ADS=3Don: Active Directory client support
     AD_DC=3Don: Active Directory Domain Controller support
     DOCS=3Don: Build and/or install documentation
     FAM=3Don: File Alteration Monitor support
     LDAP=3Don: LDAP client support
     PTHREADPOOL=3Don: Pthread pool
     SYSLOG=3Don: Syslog logging support
  *  BIND910=3Don: Use bind910 as AD DC DNS server frontend

I've included below, the unique "error"s while using a virgin build, using=
=20
# make __MAKE_CONF=3D/dev/null -C /usr/ports/net/samba44 -DBATCH
-DMAKE_JOBS_UNSAFE clean package

In file included from ../source3/auth/auth_domain.c:29:
In file included from ../source3/libsmb/libsmb.h:26:
/usr/local/include/client.h:14:8: error: unknown type name 'dlink_list'
extern dlink_list user_list;

/usr/local/include/client.h:79:10: error: use of undeclared identifier
'NICKLEN'
        char id[NICKLEN+1];

/usr/local/include/client.h:197:23: error: conflicting types for 'find_serv=
ice'
extern struct client *find_service(const char *name);

5 warnings and 19 errors generated.
Waf: Leaving directory `/usr/ports/net/samba44/work/samba-4.4.11/bin'
Build failed:  -> task failed (err #1):
        {task: cc auth_domain.c -> auth_domain_11.o}
  File "buildtools/bin/waf", line 76, in <module>
        Scripting.prepare(t, cwd, VERSION, wafdir)
  File
"/usr/ports/net/samba44/work/samba-4.4.11/third_party/waf/wafadmin/Scriptin=
g.py",
line 147, in prepare
        error(str(e))
*** Error code 1
patch-dynconfig__wscript

and for completeness there is no /usr/local/client.h, but=20

# find /usr/ports/net/samba44/work/samba-4.4.11 -name client.h
/usr/ports/net/samba44/work/samba-4.4.11/ctdb/client/client.h
/usr/ports/net/samba44/work/samba-4.4.11/source3/include/client.h

Please note that these are different errors from my build, which did surpri=
se
me.  I'll need to investigate further as we're also rebuilding FreeBSD
11.Stable 3 evenings a week at the moment (though I strongly doubt that as a
cause).

And thanks for the suggestion Mathieu.  I did try building 4.5 a few weeks =
ago.
 Unfortunately its quite challenging, and if you examine both the samba cha=
nge
logs (or monitor the samba technical lists) you'll notice that there are al=
so
some changes required to accomodate the os kernel; and jumping to the relea=
sed
samba46 would be better use of effort. ;) Historically Timur has tracked th=
ese
changes and as you can see from /usr/ports/net/samba44/files many of the
FreeBSD customisations for samba are non-trivial; and beyond me (as I have =
been
absent from C programming for 27 years).

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-217993-13-6OCVmuwwr8>