From owner-svn-src-head@freebsd.org Wed Sep 23 15:21:10 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 370BEA07D3E; Wed, 23 Sep 2015 15:21:10 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 199C61D1D; Wed, 23 Sep 2015 15:21:10 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 0EB3419AB; Wed, 23 Sep 2015 15:21:10 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id C09CC13142; Wed, 23 Sep 2015 15:21:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id t6X3854UchgB; Wed, 23 Sep 2015 15:21:03 +0000 (UTC) Subject: Re: svn commit: r286995 - head/share/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com F0E911313C To: Baptiste Daroussin References: <201508211515.t7LFFM0U028322@repo.freebsd.org> <56023395.2080904@FreeBSD.org> <20150923062541.GH16800@ivaldir.etoilebsd.net> Cc: Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <5602C35D.1030408@FreeBSD.org> Date: Wed, 23 Sep 2015 08:21:01 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150923062541.GH16800@ivaldir.etoilebsd.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="iI0jxQDCqGlFX7wOokEsUEcf8jeVx3jVI" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2015 15:21:10 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iI0jxQDCqGlFX7wOokEsUEcf8jeVx3jVI Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 9/22/2015 11:25 PM, Baptiste Daroussin wrote: > On Tue, Sep 22, 2015 at 10:07:33PM -0700, Bryan Drewery wrote: >> On 8/21/15 8:15 AM, Warner Losh wrote: >>> Author: imp >>> Date: Fri Aug 21 15:15:22 2015 >>> New Revision: 286995 >>> URL: https://svnweb.freebsd.org/changeset/base/286995 >>> >>> Log: >>> Document bsd.progs.mk, including its status as being strongly >>> discouraged and that it will be going away as soon as is practicabl= e. >>> >>> Modified: >>> head/share/mk/bsd.README >> >> I find this functionality irreplaceable for simplicity. The alternativ= e >> is more Makefiles for simple extra progs. Granted it has meta mode >> dirdeps issues but I think that is acceptable as there are other ways = to >> address that. >> >> Where is this deprecation coming from? Is it just due to bapt's >> in-progress (but not working) patch at https://reviews.freebsd.org/D34= 44 >> to remove bsd.progs.mk in place of PROGS in bsd.prog.mk? >> >> I would like to document PROGS properly. I had no idea how it worked >> until reading over it tonight. If the plan wasn't to remove PROGS itse= lf >> I will do so. >> > This is the exact opposite. >=20 > the review comes from the fact that bsd.progs.mk is broken.and has not = be fixed > for a while. The brokenness comes from the fact it is including magical= ly > bsd.prog.mk multiple times, the easiy to see brokenness is the fact tha= t > everything defining FILES/SCRIPTS and other magic macros that bsd.prog.= mk accept > via it multiple inputs will be reinstalled multiple times, one can fix = those by > exhaustively adding overwrites of every single macros, but hat would be= really > tedious each time one of the thing included in bsd.prog.mk get modified= or added >=20 I have fixed this actually. I am committing today. > You can easily see that for all the bsd.tests.mk. >=20 > While I do really like the fonctionnality it is very complicticated to = get it > working. >=20 > My work in progress version is eaily fixable by adding: > https://lists.freebsd.org/pipermail/freebsd-arch/2003-June/000906.html >=20 > And extending the above for LDFLAGS and CXXFLAGS. >=20 > Which had been rejected in the past multiple times :( >=20 > The subject came back again > https://lists.freebsd.org/pipermail/freebsd-arch/2010-September/010613.= html >=20 > I think D3444 would be a good excuse to bring back the idea of perfiles= specific > FLAGS. But I didn't want to wake up dead subject noone agreed on. >=20 > Best regards, > Bapt >=20 --=20 Regards, Bryan Drewery --iI0jxQDCqGlFX7wOokEsUEcf8jeVx3jVI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWAsNdAAoJEDXXcbtuRpfPnycIAKdy9a1JSpeJ4cicBLG3xw/g uqPDWenKbhfQdFJ8kFA93Tuy0g3VCA3c541f+bun+ef39q+LGzAnSffZX2g5AUcU 53JDWLl7vrq19loQXjfD/uEAuatJdfijDZKX+wQTKAEA+FgYmmOLbNJoPtoiTIGb Rnghe+FBAxYCM/ENzO/dBTAoNS1m0MmkpvqKvPRGELLF/Ux5D4urU+UTZP2OY32i IM3GEH0+keo0Pf2ivHD0Affg4uMbD3JpsoifAERGMIv+HIA6dyf4fhl1zbC8hj8Q LdmIXKri3Ndzdu4/hfLkCDlw8Kzu+lKiOw+ZROA56/XitZcENrJOHJjUKqbX18Q= =2AuN -----END PGP SIGNATURE----- --iI0jxQDCqGlFX7wOokEsUEcf8jeVx3jVI--