Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 Sep 2015 08:21:01 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r286995 - head/share/mk
Message-ID:  <5602C35D.1030408@FreeBSD.org>
In-Reply-To: <20150923062541.GH16800@ivaldir.etoilebsd.net>
References:  <201508211515.t7LFFM0U028322@repo.freebsd.org> <56023395.2080904@FreeBSD.org> <20150923062541.GH16800@ivaldir.etoilebsd.net>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--iI0jxQDCqGlFX7wOokEsUEcf8jeVx3jVI
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 9/22/2015 11:25 PM, Baptiste Daroussin wrote:
> On Tue, Sep 22, 2015 at 10:07:33PM -0700, Bryan Drewery wrote:
>> On 8/21/15 8:15 AM, Warner Losh wrote:
>>> Author: imp
>>> Date: Fri Aug 21 15:15:22 2015
>>> New Revision: 286995
>>> URL: https://svnweb.freebsd.org/changeset/base/286995
>>>
>>> Log:
>>>   Document bsd.progs.mk, including its status as being strongly
>>>   discouraged and that it will be going away as soon as is practicabl=
e.
>>>
>>> Modified:
>>>   head/share/mk/bsd.README
>>
>> I find this functionality irreplaceable for simplicity. The alternativ=
e
>> is more Makefiles for simple extra progs. Granted it has meta mode
>> dirdeps issues but I think that is acceptable as there are other ways =
to
>> address that.
>>
>> Where is this deprecation coming from? Is it just due to bapt's
>> in-progress (but not working) patch at https://reviews.freebsd.org/D34=
44
>> to remove bsd.progs.mk in place of PROGS in bsd.prog.mk?
>>
>> I would like to document PROGS properly. I had no idea how it worked
>> until reading over it tonight. If the plan wasn't to remove PROGS itse=
lf
>> I will do so.
>>
> This is the exact opposite.
>=20
> the review comes from the fact that bsd.progs.mk is broken.and has not =
be fixed
> for a while. The brokenness comes from the fact it is including magical=
ly
> bsd.prog.mk multiple times, the easiy to see brokenness is the fact tha=
t
> everything defining FILES/SCRIPTS and other magic macros that bsd.prog.=
mk accept
> via it multiple inputs will be reinstalled multiple times, one can fix =
those by
> exhaustively adding overwrites of every single macros, but hat would be=
 really
> tedious each time one of the thing included in bsd.prog.mk get modified=
 or added
>=20

I have fixed this actually. I am committing today.

> You can easily see that for all the bsd.tests.mk.
>=20
> While I do really like the fonctionnality it is very complicticated to =
get it
> working.
>=20
> My work in progress version is eaily fixable by adding:
> https://lists.freebsd.org/pipermail/freebsd-arch/2003-June/000906.html
>=20
> And extending the above for LDFLAGS and CXXFLAGS.
>=20
> Which had been rejected in the past multiple times :(
>=20
> The subject came back again
> https://lists.freebsd.org/pipermail/freebsd-arch/2010-September/010613.=
html
>=20
> I think D3444 would be a good excuse to bring back the idea of perfiles=
 specific
> FLAGS. But I didn't want to wake up dead subject noone agreed on.
>=20
> Best regards,
> Bapt
>=20


--=20
Regards,
Bryan Drewery


--iI0jxQDCqGlFX7wOokEsUEcf8jeVx3jVI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJWAsNdAAoJEDXXcbtuRpfPnycIAKdy9a1JSpeJ4cicBLG3xw/g
uqPDWenKbhfQdFJ8kFA93Tuy0g3VCA3c541f+bun+ef39q+LGzAnSffZX2g5AUcU
53JDWLl7vrq19loQXjfD/uEAuatJdfijDZKX+wQTKAEA+FgYmmOLbNJoPtoiTIGb
Rnghe+FBAxYCM/ENzO/dBTAoNS1m0MmkpvqKvPRGELLF/Ux5D4urU+UTZP2OY32i
IM3GEH0+keo0Pf2ivHD0Affg4uMbD3JpsoifAERGMIv+HIA6dyf4fhl1zbC8hj8Q
LdmIXKri3Ndzdu4/hfLkCDlw8Kzu+lKiOw+ZROA56/XitZcENrJOHJjUKqbX18Q=
=2AuN
-----END PGP SIGNATURE-----

--iI0jxQDCqGlFX7wOokEsUEcf8jeVx3jVI--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5602C35D.1030408>