From owner-freebsd-threads@FreeBSD.ORG  Wed May  4 23:40:30 2005
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8033A16A4CE; Wed,  4 May 2005 23:40:30 +0000 (GMT)
Received: from mailhost.stack.nl (vaak.stack.nl [131.155.140.140])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 349E043D1F; Wed,  4 May 2005 23:40:30 +0000 (GMT)
	(envelope-from marcolz@stack.nl)
Received: from hammer.stack.nl (hammer.stack.nl
	[IPv6:2001:610:1108:5010::153])
	by mailhost.stack.nl (Postfix) with ESMTP id E32311F0E1;
	Thu,  5 May 2005 01:39:25 +0200 (CEST)
Received: by hammer.stack.nl (Postfix, from userid 333)
	id C77C06393; Thu,  5 May 2005 01:39:25 +0200 (CEST)
Date: Thu, 5 May 2005 01:39:25 +0200
From: Marc Olzheim <marcolz@stack.nl>
To: David Schultz <das@freebsd.org>
Message-ID: <20050504233925.GA3436@stack.nl>
References: <20050504205745.GH76171@stack.nl>
	<Pine.GSO.4.43.0505041741310.498-100000@sea.ntplx.net>
	<20050504221825.GA22732@VARK.MIT.EDU>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd"
Content-Disposition: inline
In-Reply-To: <20050504221825.GA22732@VARK.MIT.EDU>
X-Operating-System: FreeBSD hammer.stack.nl 5.4-STABLE FreeBSD 5.4-STABLE
X-URL: http://www.stack.nl/~marcolz/
User-Agent: Mutt/1.5.9i
cc: Daniel Eischen <deischen@freebsd.org>
cc: Marc Olzheim <marcolz@stack.nl>
cc: freebsd-threads@freebsd.org
Subject: Re: Floating point exceptions with -pthread
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 May 2005 23:40:30 -0000


--ZPt4rx8FFjLCG7dd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, May 04, 2005 at 06:18:25PM -0400, David Schultz wrote:
> Yeah, that part is fine.  The one odd thing I notice as a glance
> back at the code is that it uses -12(%ebp) and -16(%ebp) for
> temporary storage, instead of using -4(%ebp) and -8(%ebp) like
> the double versions.  That's probably a cut-and-pasto on my
> part.

*doh*

NetBSD cvsweb /usr/src/lib/libm/arch/i387/s_floorf.S:

-----8<---------8<-----------8<-----
Revision 1.3.16.1 / (download) - annotate - [select for diffs], Thu Mar 28 22:55:09 2002 UTC (3 years, 1 month ago) by he
Branch: netbsd-1-5
CVS Tags: netbsd-1-5-PATCH003
Changes since 1.3: +6 -6 lines
Diff to previous 1.3 (colored) next main 1.4 (colored)

Pull up revision 1.5 (requested by fvdl):
  Fix stack usage so that a signal delivered in ceil() or floor()
  no longer corrupts the stack.
-----8<---------8<-----------8<-----

Versions before it looked an awful lot like the one we just fixed. :-/

It seems as though a look into the other NetBSD patches might be
worthwile...

Marc

--ZPt4rx8FFjLCG7dd
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (FreeBSD)

iD8DBQFCeV0tezjnobFOgrERAnkVAKDHa3EuK4+msHxn4EznuLLsZ1K8HwCgo4jK
0la8NLb7HtzPCnqS0bI98jI=
=qp+2
-----END PGP SIGNATURE-----

--ZPt4rx8FFjLCG7dd--