From owner-freebsd-bugs Wed Apr 24 5:41: 2 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 889AF37B405 for ; Wed, 24 Apr 2002 05:40:59 -0700 (PDT) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g3OCe3E97926; Wed, 24 Apr 2002 05:40:03 -0700 (PDT) (envelope-from gnats) Date: Wed, 24 Apr 2002 05:40:03 -0700 (PDT) Message-Id: <200204241240.g3OCe3E97926@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Dominic Marks Subject: Re: kern/35720: Patch to vr(4) to fix network load problems Reply-To: Dominic Marks Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR kern/35720; it has been noted by GNATS. From: Dominic Marks To: The Anarcat Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: kern/35720: Patch to vr(4) to fix network load problems Date: Wed, 24 Apr 2002 13:29:36 +0100 On Wed, Apr 24, 2002 at 12:50:52AM -0400, The Anarcat wrote: > I had to hack the source to apply the patch on -stable. I can confirm > the fix works on stable, please commit! How much load have you tested this under? > The .h file is not affected. > > --- if_vr.c.orig Sun Dec 16 10:46:08 2001 > +++ if_vr.c Wed Apr 24 00:24:17 2002 > @@ -1308,14 +1308,24 @@ > static void vr_start(ifp) > struct ifnet *ifp; > { > + register int i; > struct vr_softc *sc; > struct mbuf *m_head = NULL; > - struct vr_chain *cur_tx = NULL, *start_tx; > + struct vr_chain *cur_tx = NULL, *start_tx, *tx_item; > > sc = ifp->if_softc; > > - if (ifp->if_flags & IFF_OACTIVE) > + if (ifp->if_flags & IFF_OACTIVE) { > + for (i = 0; i < VR_TX_LIST_CNT; i++) { > + tx_item = &sc->vr_cdata.vr_tx_chain[i]; > + if (tx_item->vr_mbuf != NULL) { > + m_freem (tx_item->vr_mbuf); > + tx_item->vr_mbuf = NULL; > + ifp->if_flags &= ~IFF_OACTIVE; > + } > + } > return; > + } > > /* > * Check for an available queue slot. If there are none, > > > -- > N'aimer qu'un seul est barbarie, car c'est au détriment de tous les > autres. Fût-ce l'amour de Dieu. > - Nietzsche, "Par delà le bien et le mal" -- Dominic To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message