From owner-svn-src-head@freebsd.org Thu May 18 13:09:33 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C8F53D724D0; Thu, 18 May 2017 13:09:33 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 812051BEA; Thu, 18 May 2017 13:09:33 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by freefall.freebsd.org (Postfix, from userid 1235) id A73E67400; Thu, 18 May 2017 13:09:32 +0000 (UTC) Date: Thu, 18 May 2017 15:09:32 +0200 From: Baptiste Daroussin To: rgrimes@freebsd.org Cc: Ngie Cooper , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r318441 - in head/etc: . cron.d Message-ID: <20170518130932.eo5clhki4za2vigz@ivaldir.net> References: <201705180625.v4I6Pd9j062495@repo.freebsd.org> <201705180956.v4I9uVpQ065465@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hkqzmaj2eaimfgcz" Content-Disposition: inline In-Reply-To: <201705180956.v4I9uVpQ065465@pdx.rh.CN85.dnsmgr.net> User-Agent: NeoMutt/20170428 (1.8.2) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 May 2017 13:09:33 -0000 --hkqzmaj2eaimfgcz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 18, 2017 at 02:56:31AM -0700, Rodney W. Grimes wrote: > > Author: ngie > > Date: Thu May 18 06:25:39 2017 > > New Revision: 318441 > > URL: https://svnweb.freebsd.org/changeset/base/318441 > >=20 > > Log: > > Handle the cron.d entry for MK_AT in cron conditionally > > =20 > > Install /etc/cron.d/at if MK_AT !=3D no, always using it, which tries > > to run a non-existent program via cron(8) every 5 minutes with the > > default /etc/crontab, prior to this commit. > > =20 > > SHELL and PATH are duplicated between /etc/crontab and /etc/cron.d/at > > because atrun(8) executes programs, which may rely on environment > > currently set via /etc/crontab. > > =20 > > Noted by: bdrewery (in an internal review) > > MFC after: 2 months > > Relnotes: yes (may need to add environmental modifications to > > /etc/cron.d/at) > > Sponsored by: Dell EMC Isilon > >=20 > > Added: > > head/etc/cron.d/ > > head/etc/cron.d/Makefile (contents, props changed) > > head/etc/cron.d/at (contents, props changed) > > Modified: > > head/etc/Makefile > > head/etc/crontab > >=20 > > Modified: head/etc/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/etc/Makefile Thu May 18 06:15:42 2017 (r318440) > > +++ head/etc/Makefile Thu May 18 06:25:39 2017 (r318441) > > @@ -8,6 +8,7 @@ FILESGROUPS=3D FILES > > # No need as it is empty and just causes rebuilds since this file does= so much. > > UPDATE_DEPENDFILE=3D no > > SUBDIR=3D \ > > + cron.d \ > > newsyslog.conf.d \ > > syslog.d >=20 > The thread on the newsyslog clearly shows that this is a contriversial ch= ange. >=20 > I strongly object to further splitting of /etc/FOO into /etc/foo.d/FOO fi= les > to suite Dell/EMC/Isilon's needs. It is in conflict with the needs and > desires of others. Has multiple people has stated, on the newsyslog thread. this is not a DELL/EMC/Isilon need, this is also a requirement for plenty of use cases 1. Consistency as a project we do support building WITHOUT_FOO there is no reason to ins= tall syslog, cron configuration for FOO if the system was built without foo 2. Packaging base if one does not install at there is no need for the at crontab to be inst= alled (same reason as 1.) 3. Large deployment of freebsd farms Being able to administrate thousands of FreeBSD machines, one often ends = up using tools like puppet, chef, ansible, cfengine. When programmatically handling configuration management it is way easier and safer to simple add/removes files in a directory rather than mangling^Winplace editing fi= les. 4. Ports/packages On can provide easily sample configuration for cron, syslog (not only) an= d the admin can decide to use it or not easily (ususally this is done by making symlinks from the said file which would live in share/* into the .d direc= tory. This is not a new trend in FreeBSD: newsyslog, rc.conf, libmap and more. Best regards, Bapt --hkqzmaj2eaimfgcz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlkdnQkACgkQY4mL3PG3 PlphKw//S2nZH85ZFQ5miEw9PbpWRR63V9cHp3M/OhT63hPeZ1TIXcU6Y3dPEKPU zCUjSeds8bZDKauR9ifPy1HhUzuvSIcJNQCaErCLE4l/F3Zc3jUC/nTQ7vsF1FGf lKf41fsoXnVuurBOhubmLwBu9BYjfw4grWPmJzIx1gv5mnYF9wf80d40VdsEOr6/ 4c/lErNr0B3RcWFq6yv93cYLDxCkGK0pxq1XJpQO1WygRYqBYZLvBwHAUG6/02Vi V0Piyu6apBzHvDyWoncrULYCtfF7UtxdGmdOQVH3arCNSBHtOUd1oZEtku0G6Qcc yHWAzqB8imZWQ9Hko9JX/Xmuqp2CUWLZNsmRxpwpGMbgplSoov4hZNFtiPMQlVhm v1j1uXOOPhVG/8wXqVewGf8A8om6GL2fHarMZ0OssZ5RAN9+zctdNL2+GUxqLsNH s/1Cx/UUoCx0cLiSBkWdpIhEzv3EYxGdzkTFIpFqMu9/RIrknmtlv+tibfHHivlQ 7PMpaUSk/P6mSLj/WDHo9cIxBQ1P0z+qs2Wqa+ALyhNpXo1fYZdAEKNGVM2Lzma5 Lez6+uHOto9hgWJmjG45oGgz34thRT4xg0iy56FwKpYBFXHiiP7879/Oi17fR+32 2c2/k6b37cMt3WA5bsBiyyw7zdpAFiHq5sSAUa33in8P5nc+JWM= =GELL -----END PGP SIGNATURE----- --hkqzmaj2eaimfgcz--