From owner-dev-commits-src-main@freebsd.org Fri May 21 14:11:38 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BBE1A633755 for ; Fri, 21 May 2021 14:11:38 +0000 (UTC) (envelope-from mw@semihalf.com) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FmpSV4TQQz3QKr for ; Fri, 21 May 2021 14:11:38 +0000 (UTC) (envelope-from mw@semihalf.com) Received: by mail-qk1-x731.google.com with SMTP id i5so12582386qkf.12 for ; Fri, 21 May 2021 07:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RhDjwBklaIBDR8oby7gettn6bdTQ5xD+H7vR/fEk7ns=; b=U/EXKUXZUtcuScw/yBlhiZIBQVEQxKb5vaLwF4abTqhoVIHYi9Ll2b/4q0R1crMuQc qH0EkAufY09a3S4/oEX9xP1WIpMLsZz1P1fScDoi4J3N4DXbGCemoYaI0nl7ctPNCmtb 2iBlk1Knjgd+Poe7GI3ZLvxnAWWXZnmQCpXuwWQ40rMWlGwP0CtNlWepBPBgrmb1cErn Pf2SYXeery35Lk75vBGROGZOeRuudR6Y6EbxCrb/o2YxGhvgs812ddRqmlmHAa6XaAtR djLu7fLVK1KuobJj5zNVaaNkEItLlKb/lJMUtez811SlY8l00LKb/wxc/qbPt3HV05hR RtGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RhDjwBklaIBDR8oby7gettn6bdTQ5xD+H7vR/fEk7ns=; b=Je46kSc5uckKhVfmY6tHjRPu2mHHncUp/mgQBbt52SWLYG5V/RNWj9oiM14qqrrYfq ABuSJNLPffGuCKBmWnZlq0e28JtlumlPDHjJMfLGPtv2YwSlJv0Y8Jx1kgx7wcntzZdw U0nIdhjhMd2unNeV3/zD5OmIzY6yBpvo/FhkPaWLieyT72VTMdGkxFaZixGFXFNEUsu8 tOZpvwOFaG6XCxWaPEU8nkzWPmzsQ56q0eMqHidXXXI4iWhmCNWd1GCwwVT7rwfZj6fx u5ETcOQlVP/YeFkZpbQi9C+c8UeafziGHaRWjGFdQUpM65+b8LYDPy2n8zM6yzlt3nsK Mz/Q== X-Gm-Message-State: AOAM530eUhNL63wDPX1Kc1DCpwOkCy7csuy134GRI0ChlA6xI93CCDIo 1101TiljtcjIhIinhWwQe9pNBS8uXeYflGO+9V0/4w== X-Google-Smtp-Source: ABdhPJyqnEWijB/41rLoJSltLnpTA1rch/rGkbRU8jjdiIw8x7Ywb67/c9/+oaaKD9XLK/ULsLwNarq21tz9H4bgbPg= X-Received: by 2002:a05:620a:2a0f:: with SMTP id o15mr12118873qkp.295.1621606297698; Fri, 21 May 2021 07:11:37 -0700 (PDT) MIME-Version: 1.0 References: <202105211334.14LDYqoa004343@gitrepo.freebsd.org> <04F25FD0-7863-4AC1-A257-EF0F1EB90659@freebsd.org> In-Reply-To: <04F25FD0-7863-4AC1-A257-EF0F1EB90659@freebsd.org> From: Marcin Wojtas Date: Fri, 21 May 2021 16:11:25 +0200 Message-ID: Subject: Re: git: af949c590bd8 - main - Disable stack gap for ntpd during build. To: Jessica Clarke , shawn.webb@hardenedbsd.org Cc: Marcin Wojtas , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4FmpSV4TQQz3QKr X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2021 14:11:38 -0000 Hi Jess pt., 21 maj 2021 o 15:39 Jessica Clarke napisa=C5=82(a= ): > > On 21 May 2021, at 14:34, Marcin Wojtas wrote: > > > > The branch main has been updated by mw: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3Daf949c590bd8a00a5973b587= 5d7e0fa6832ea64a > > > > commit af949c590bd8a00a5973b5875d7e0fa6832ea64a > > Author: Marcin Wojtas > > AuthorDate: 2021-05-21 09:29:22 +0000 > > Commit: Marcin Wojtas > > CommitDate: 2021-05-21 13:33:06 +0000 > > > > Disable stack gap for ntpd during build. > > > > When starting, ntpd calls setrlimit(2) to limit maximum size of its > > stack. The stack limit chosen by ntpd is 200K, so when stack gap > > is enabled, the stack gap is larger than this limit, which results > > in ntpd crashing. > > Isn=E2=80=99t the bug that the unusable gap counts as usage? > > Jess > An alternative solution was submitted (https://reviews.freebsd.org/D29832), so that to extend the limit for ntpd, but eventually it was recommended to simple disable the stack gap for it until it's fixed upstream (see the last comment in the linked revision). Best regards, Marcin