Date: Thu, 24 Jan 2019 16:24:16 +0100 From: "Bradley T. Hughes" <bhughes@freebsd.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r491058 - head/www/node8 Message-ID: <a93f2652-b7d2-f12d-8dfd-a6807eef4d36@freebsd.org> In-Reply-To: <34d14b33-8cef-2be4-3949-85164661c1ae@freebsd.org> References: <201901232114.x0NLERHX020332@repo.freebsd.org> <20190123220008.ctao7hiv4flbms7i@atuin.in.mat.cc> <34d14b33-8cef-2be4-3949-85164661c1ae@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-01-24 05:51, Bradley T. Hughes wrote: > On 2019-01-23 23:00, Mathieu Arnold wrote: >> On Wed, Jan 23, 2019 at 09:14:27PM +0000, Bradley T. Hughes wrote: >>> - >>> -.include <bsd.port.options.mk> >>> - >>> -.if empty(PORT_OPTIONS:MBUNDLED_SSL) >>> - >>> -.if !empty(SSL_DEFAULT:Mlibressl*) >>> -IGNORE= cannot build node.js with LibreSSL. You must enable >>> BUNDLED_SSL >>> -.endif >>> - >>> -.endif >> >> Mmmm, this is not equivalent, now, the port is always marked as BROKEN >> if the op uses libressl* as their default SSL library, even if >> BUNDLED_SSL is set. >> >> And I think the other changes to the other node* ports are also wrong >> for the same reason. > > Good point, I hadn't considered that. I will fix them now :) Actually, after looking at it more, setting BUNDLED_SSL on any of the www/node* ports causes the port to skip USES+=ssl, which in turn ignores BROKEN_SSL. So, this works as I had intended it; setting DEFAULT_VERSIONS+=ssl=something only matters when BUNDLED_SSL is off, and I have set the defaults such that BUNDLED_SSL is off for FreeBSD versions that have a compatible OpenSSL in base. Changing SSL_DEFAULT can have an impact on whether or not www/node* builds, but that is circumvented by setting BUNDLED_SSL. Thank you for the feedback. I appreciate review and questions about what/how I've done. :) -- Bradley T. Hughes bhughes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a93f2652-b7d2-f12d-8dfd-a6807eef4d36>