From owner-p4-projects@FreeBSD.ORG Fri May 14 19:21:19 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 381371065676; Fri, 14 May 2010 19:21:19 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F0C101065670 for ; Fri, 14 May 2010 19:21:18 +0000 (UTC) (envelope-from jona@FreeBSD.org) Received: from repoman.freebsd.org (unknown [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C55698FC12 for ; Fri, 14 May 2010 19:21:18 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o4EJLIxE050708 for ; Fri, 14 May 2010 19:21:18 GMT (envelope-from jona@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o4EJLITx050706 for perforce@freebsd.org; Fri, 14 May 2010 19:21:18 GMT (envelope-from jona@FreeBSD.org) Date: Fri, 14 May 2010 19:21:18 GMT Message-Id: <201005141921.o4EJLITx050706@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to jona@FreeBSD.org using -f From: Jonathan Anderson To: Perforce Change Reviews Precedence: bulk Cc: Subject: PERFORCE change 178261 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2010 19:21:19 -0000 http://p4web.freebsd.org/@@178261?ac=10 Change 178261 by jona@jona-belle-freebsd8 on 2010/05/14 19:20:31 Allow fstatat() Affected files ... .. //depot/projects/trustedbsd/capabilities/src/sys/kern/capabilities.conf#27 edit .. //depot/projects/trustedbsd/capabilities/src/sys/kern/init_sysent.c#47 edit .. //depot/projects/trustedbsd/capabilities/src/sys/kern/vfs_syscalls.c#30 edit Differences ... ==== //depot/projects/trustedbsd/capabilities/src/sys/kern/capabilities.conf#27 (text+ko) ==== @@ -38,7 +38,7 @@ ## - sys_exit(2), abort2(2) and close(2) are very important. ## - Sorted alphabetically, please keep it that way. ## -## $P4: //depot/projects/trustedbsd/capabilities/src/sys/kern/capabilities.conf#26 $ +## $P4: //depot/projects/trustedbsd/capabilities/src/sys/kern/capabilities.conf#27 $ ## ## @@ -457,6 +457,7 @@ ## files which are not "under" the directory FD given to the syscall. ## faccessat +fstatat fchmodat futimesat mkdirat ==== //depot/projects/trustedbsd/capabilities/src/sys/kern/init_sysent.c#47 (text+ko) ==== @@ -527,7 +527,7 @@ { AS(fchmodat_args), (sy_call_t *)fchmodat, AUE_FCHMODAT, NULL, 0, 0, SYF_CAPENABLED }, /* 490 = fchmodat */ { AS(fchownat_args), (sy_call_t *)fchownat, AUE_FCHOWNAT, NULL, 0, 0, 0 }, /* 491 = fchownat */ { AS(fexecve_args), (sy_call_t *)fexecve, AUE_FEXECVE, NULL, 0, 0, SYF_CAPENABLED }, /* 492 = fexecve */ - { AS(fstatat_args), (sy_call_t *)fstatat, AUE_FSTATAT, NULL, 0, 0, 0 }, /* 493 = fstatat */ + { AS(fstatat_args), (sy_call_t *)fstatat, AUE_FSTATAT, NULL, 0, 0, SYF_CAPENABLED }, /* 493 = fstatat */ { AS(futimesat_args), (sy_call_t *)futimesat, AUE_FUTIMESAT, NULL, 0, 0, SYF_CAPENABLED }, /* 494 = futimesat */ { AS(linkat_args), (sy_call_t *)linkat, AUE_LINKAT, NULL, 0, 0, 0 }, /* 495 = linkat */ { AS(mkdirat_args), (sy_call_t *)mkdirat, AUE_MKDIRAT, NULL, 0, 0, SYF_CAPENABLED }, /* 496 = mkdirat */ ==== //depot/projects/trustedbsd/capabilities/src/sys/kern/vfs_syscalls.c#30 (text+ko) ==== @@ -2425,9 +2425,9 @@ if (flag & ~AT_SYMLINK_NOFOLLOW) return (EINVAL); - NDINIT_AT(&nd, LOOKUP, ((flag & AT_SYMLINK_NOFOLLOW) ? NOFOLLOW : + NDINIT_ATRIGHTS(&nd, LOOKUP, ((flag & AT_SYMLINK_NOFOLLOW) ? NOFOLLOW : FOLLOW) | LOCKSHARED | LOCKLEAF | AUDITVNODE1 | MPSAFE, pathseg, - path, fd, td); + path, fd, CAP_FSTAT | CAP_ATBASE, td); if ((error = namei(&nd)) != 0) return (error);