From nobody Wed Aug 5 15:16:42 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hFYsk4xVKz6nQYv for ; Wed, 05 Aug 2026 15:16:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hFYsk1WWpz3w0k for ; Wed, 05 Aug 2026 15:16:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785943002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BP780296fVt46ydhVAhaMuHMPzZ8apXmBN9d8iaCMew=; b=UT/85ej2x13tqTko3RY3C48rS8zysaUB7LsSh2n/wz2AR3tIRxhCB0VOm/eOU54ooYyHc7 G2mhgFdasuWlbbmPD+CJU5m4nSHvd4MYt4Pramn4foS4/tX2Kl4Ij8q2kcs78YxAfrgrzF +niAyoIE+iW8++kU2LKbU2ZtiOKdXq5fK8Q3hgB+rn4NEqtMfDHrcmE0BhY2OBnefIqYSP Ycpw2SjGCS3ErU+Ueq6rHtRpw2fiyD1svB16rKK/tquEg2rRFKO3xpMFZyHvzXd93wBHhi RtQ0CUQYEtstPkxCyA4C60Uv2kyF5amdFu4uJgcip7XdhbNEiib5YO14vBbMwQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785943002; a=rsa-sha256; cv=none; b=bkKz3CWhScZooXbu7ft9OdzsZXrKF+t/1SoKySNsGS7O4TIz5H7o2K514Nm7TYs8Afrige s2cbpIjxjHDLO2WG4/WL2E6VATF6jI/J1JfILasCZtbpxC1/us/2WktIz5qZbIbNKYKWSC ch9TrpdFdjT1f9+gqK880qtzaXlbfwp1AowBi+czy7uHnn96kp+PCGTbvVXJxQ/12n+5OR c8ZLzWVoJ+laryhbJTxeKr+4N0D6LoTtQ5B4+tWjnts4NLbHGOme5VUsgG3mpoU/MLV3zY /8zRp0uRQC0ssx71m4+cyd7HzcQ4V6oJAjNfTO10ro9zLJhr4q2FrGhXcfx64Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785943002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BP780296fVt46ydhVAhaMuHMPzZ8apXmBN9d8iaCMew=; b=dG0ZqWZFJPYUFuCV045yqWRebF/vqUwzXiyz/mOLNrcAz6rzYJ3KFe3Re836hQK/t0fy8H NSGZK3zjy+bJ2SRuCZ1q9qTJTbx/IaC6va1I9H/PVyVrcyvxkQHgDOMqiKWxfy/J66nEQ1 RKHC5igiHU8fnAlmkxbsYcpe/zfU5/AmtHd3fig1M7KjuGo/+I1VT0hR13nTXV6CgZMNgJ HDR9XjmptmB4L2EkCzFO+eODUj6EUiE61Piw9WptDthoOFweY7nC3jDy5lrb5kHIaclorv dVg61QES00JUmjzNjSSWOOQ/z5Uod3zLR9SyRVsnjsWDAwk+uQt7mvxIvzVBxA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hFYsk0J8GzfYZ for ; Wed, 05 Aug 2026 15:16:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 46d54 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 05 Aug 2026 15:16:42 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Konstantin Belousov From: Mark Johnston Subject: git: e8c54222acdb - stable/14 - inotify: do not call into namei() with a locked vnode List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: e8c54222acdbb977c4164667627b6ee569d2eb90 Auto-Submitted: auto-generated Date: Wed, 05 Aug 2026 15:16:42 +0000 Message-Id: <6a7353da.46d54.51c4cd26@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=e8c54222acdbb977c4164667627b6ee569d2eb90 commit e8c54222acdbb977c4164667627b6ee569d2eb90 Author: Konstantin Belousov AuthorDate: 2025-07-10 07:15:13 +0000 Commit: Mark Johnston CommitDate: 2026-08-05 15:15:16 +0000 inotify: do not call into namei() with a locked vnode PR: 288127 Reviewed by: markj Fixes: f1f230439fa48581f40a57f095627f667a9713c3 Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D51233 (cherry picked from commit 63389aea24f15fe823c775960d77017f1a35f54b) --- sys/kern/vfs_inotify.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/kern/vfs_inotify.c b/sys/kern/vfs_inotify.c index 8c9e7599b888..46971c78440c 100644 --- a/sys/kern/vfs_inotify.c +++ b/sys/kern/vfs_inotify.c @@ -757,9 +757,11 @@ vn_inotify_add_watch(struct vnode *vp, struct inotify_softc *sc, uint32_t mask, * directory if it's specified as a vnode. */ vrefact(vp); + VOP_UNLOCK(vp); NDINIT_ATVP(&nd, LOOKUP, NOFOLLOW, UIO_SYSSPACE, dp->d_name, vp); error = namei(&nd); + vn_lock(vp, LK_SHARED | LK_RETRY); if (error != 0) break; vn_irflag_set_cond(nd.ni_vp, VIRF_INOTIFY_PARENT);