From owner-svn-src-all@FreeBSD.ORG Tue Jul 19 01:54:56 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 07EFC106564A; Tue, 19 Jul 2011 01:54:56 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4]) by mx1.freebsd.org (Postfix) with ESMTP id A82FE8FC14; Tue, 19 Jul 2011 01:54:55 +0000 (UTC) Received: from sa-nc-spg-102.static.jnpr.net (natint3.juniper.net [66.129.224.36]) (authenticated bits=0) by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id p6J1snN5087811 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 18 Jul 2011 18:54:54 -0700 (PDT) (envelope-from marcel@xcllnt.net) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Marcel Moolenaar In-Reply-To: Date: Mon, 18 Jul 2011 18:54:44 -0700 Content-Transfer-Encoding: 7bit Message-Id: References: <201107181519.p6IFJfOK028280@svn.freebsd.org> <208D139E-CDC3-428D-8D5F-F772BFAF164C@xcllnt.net> To: Attilio Rao X-Mailer: Apple Mail (2.1084) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r224187 - in head: sys/amd64/amd64 sys/arm/arm sys/arm/sa11x0 sys/i386/i386 sys/ia64/ia64 sys/kern sys/mips/mips sys/powerpc/aim sys/powerpc/booke sys/sparc64/sparc64 sys/sys usr.bin/vm... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2011 01:54:56 -0000 On Jul 18, 2011, at 5:59 PM, Attilio Rao wrote: > 2011/7/19 Marcel Moolenaar : >> >> On Jul 18, 2011, at 8:19 AM, Attilio Rao wrote: >> >>> Author: attilio >>> Date: Mon Jul 18 15:19:40 2011 >>> New Revision: 224187 >>> URL: http://svn.freebsd.org/changeset/base/224187 >>> >>> Log: >>> - Remove the eintrcnt/eintrnames usage and introduce the concept of >>> sintrcnt/sintrnames which are symbols containing the size of the 2 >>> tables. >>> - For amd64/i386 remove the storage of intr* stuff from assembly files. >>> This area can be widely improved by applying the same to other >>> architectures and likely finding an unified approach among them and >>> move the whole code to be MI. More work in this area is expected to >>> happen fairly soon. >>> >>> No MFC is previewed for this patch. >> >> You just broke ia64 and possibly other 64-bit architectures: >> >> ".word" declares a 16-bit integral on ia64 and the size symbols >> are of type size_t (=64 bit). We'll be having misaligned loads >> (= kernel panics) and/or reading garbage... > > I'm a bit surprised of this though. > .hword was supposed to be the 16-bit integral, while .word was > supposed to be the 32-bits one, if I read my "info as" on amd64. Well... all I can say is that assembly is the least transposable language, besides of course machine code itself :-) > Anyway, what do you think about this patch? (I still need to test it): > http://www.freebsd.org/~attilio/64bits-fixup.diff Looks good to me, though I don't know enough about mips to comment on that. I'm not going to be anal about the use of ".quad" instead of "data8" for ia64 -- let's get it fixed first (I think we have ".byte" in locore.S anyway :-) -- Marcel Moolenaar marcel@xcllnt.net