From owner-svn-src-all@freebsd.org Tue Mar 12 16:57:42 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C3CF1536995 for ; Tue, 12 Mar 2019 16:57:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 33F6F7117D for ; Tue, 12 Mar 2019 16:57:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72f.google.com with SMTP id n6so1896393qkf.1 for ; Tue, 12 Mar 2019 09:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FBEWqA5PDPvuVAUL+O2i6EfVdtDNr4YvbJDAtQPza0A=; b=PXnmv3ASDlI0emPsKIs7NfUHY9MQ5U4Lkxa1mtBDE+caxetsKMOMGsYM/o8z55uUPK q2lVuqNa6/SEKDNbS0yKZSPOCALxH42qaZEQW+g1lbe+xZAt0miVSRWEjhQG9lQ1KxHH 8+/PvJazg9AxAN1jz7nZHtCQ3tV6M48mcT+O/JTPoQBibF1ZM+DL2ejlg6rxpaY7Ca2i r2ZX4YgzGD+he1l43N1vfzcEom/SquNey67fPXb/BSSaK1cXk6g7X9QHaa8arEEcfcrQ +4Ik0wbsE0VuwX89ieGOst+LysYHg3mENZNIW9Rji2UfzaNfaJDEkRjsVNj8HfMFajer s+ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FBEWqA5PDPvuVAUL+O2i6EfVdtDNr4YvbJDAtQPza0A=; b=fogCe+qINJn2Rs8LoBknEdtGHBrVshwBlHR1tqUV2/mAKUhNexR/v2Jk3DRXdo7kvH 7aQ5bTIeGdqnfp67+0Ue7cCoZNGxWrmNsvQaQ/5fNuU+p+S0sYwfLcQIKtVHNISZSU8O fLamk7ODwgfiQ3pqggyPrAy2y+XrHCJvoHu/l810enAuZzFqeKpRZqe7Ct2crnQvGukg eOO+SjpYs9PA3bOWDhJqXWlTHF/CooPR6wYRO4fHsGOQ4rwPei+euejM2Ws2BTlI5j2K igwUYWpCsQoRVS2CUdLcuzWnKNABvsBEfh5EoJWD2c50PkQSS5H17D0IYNHs7SWRufhC b4GQ== X-Gm-Message-State: APjAAAXr9y/ZKoycIX7mnAmz/vUjb39CNX5AAmHiWMnrhjPdqGztSQ7l SW8YDbUcV9mkyIMRqMdhzXeFhDTHpIPSgx0xD8p8Vg== X-Google-Smtp-Source: APXvYqyM1/uXgy0EJpUs6NZbHyxOSWy87ssn98sUEwSDHASukOBx/bAv9tvpXcFtJWQ05eX6DQMqGO2j25zAbHYfzjw= X-Received: by 2002:a37:a34f:: with SMTP id m76mr5698309qke.245.1552409861393; Tue, 12 Mar 2019 09:57:41 -0700 (PDT) MIME-Version: 1.0 References: <201903120515.x2C5Fbtw013485@gndrsh.dnsmgr.net> <201903120525.x2C5PH7X013552@gndrsh.dnsmgr.net> In-Reply-To: From: Warner Losh Date: Tue, 12 Mar 2019 10:57:30 -0600 Message-ID: Subject: Re: svn commit: r345050 - head/bin/date To: John Baldwin Cc: "Rodney W. Grimes" , Warner Losh , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 33F6F7117D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.965,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2019 16:57:42 -0000 On Tue, Mar 12, 2019, 9:43 AM John Baldwin wrote: > On 3/11/19 10:43 PM, Warner Losh wrote: > > On Mon, Mar 11, 2019 at 11:25 PM Rodney W. Grimes < > freebsd@gndrsh.dnsmgr.net> > > wrote: > > > >>>> Author: imp > >>>> Date: Tue Mar 12 04:49:59 2019 > >>>> New Revision: 345050 > >>>> URL: https://svnweb.freebsd.org/changeset/base/345050 > >>>> > >>>> Log: > >>>> Remove now useless -d and -t flags. > >>>> > >>>> These were used to set dst flag and minutes west of UTC > >>>> respectively. These are obsolete and have been removed form the > >>>> kernel. These existed primarily to faithfully emulate early > >>>> Unix ABIs that have been removed from FreeBSD. > >>>> > >>>> Reviewed by: jbh@, brooks@ > >> Nits: jhb@ and I see he did comment in the review, but he did not > >> accept it as a reviewew at the top. > >> > > > > This is why I think just the reference to the differential revision is > > perfectly fine. Why duplicate data? Others complained I hadn't included > it. > > He commented, we discussed it on irc (though most of it was about how to > > use arc better), etc. I thought it warranted it. So please don't nitpick. > > This level is really annoying and frustrating. Does this really help us > > produce a better product? > > To be fair, we have been pretty consistent that 'Reviewed by' in the commit > means 'Accepted' in phab. I probably would have ended up accepting this > anyway and just didn't click the box, so it's ok. However, we have had > folks in the past who were tagged in the past and gave feedback, but didn't > approve of the change, but were listed as 'Reviewed by' hence the current > practice. > But we talked about it outside phab, which to my mind puts it under the old rules. And it's not Rod's job to police this detail. It would be up to you to hassle me if I misinterpreted that extra communication wrong. Warner >