From owner-svn-src-head@freebsd.org Wed Dec 7 22:10:01 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B0AEC6CB85; Wed, 7 Dec 2016 22:10:01 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk0-x242.google.com (mail-qk0-x242.google.com [IPv6:2607:f8b0:400d:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 398E7AE8; Wed, 7 Dec 2016 22:10:01 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk0-x242.google.com with SMTP id n204so50505011qke.2; Wed, 07 Dec 2016 14:10:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qyuyOx2WRLgDF+Zw4r9mFRrtvmhty3hWABH0uE1EhAY=; b=VuicaetKoiihbjWlt6tdpbVdu3Z+LoDL7C7xntMxMJYtnQ92hFqbyQzQ++hkrpQX0l SQ/gi74nhE1huu9OBZiqtz2g+T/Et/wGqKNr79n6jZ18GDH3Fh12U3D2Ga7TYua1PGoA zJQ3cEmKimxkbJ3p10Yh9nqT5jiSAzEb5sk6r9+cYpWMzYY9dbNao0iwRN/iaVIVNrCc VQI1IML1PLuoLnSPZVlfMz/rDi/9IeP3BFOStuwDURNu4l90QcGLC5eIaqyzfRqwpCHJ g66Ny1x62BCeuOj23A90fXlYLE0g+juCtSf8tF7ILm0mUKaNqi8a80njn6WNvq1M+cpA tKkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=qyuyOx2WRLgDF+Zw4r9mFRrtvmhty3hWABH0uE1EhAY=; b=blLNNKXnqmWi/SW+KYHnVVGsh3IUsLzDY0vF1lFDO8kcNaWJV8xhNIgE6jw0aWJGdE Rh8jyzVA09yQXEgtx/1ABfdhQvQXnJ/0TMULivYDrh+2TxXoX252c0ucVDNltxAcB45f sJbrKxn2yC6To8Tiujdtage8jfkA2TN9galA+iZo1sHc9W3K9ZCBcQq/9dKFqzn5z0t1 R7H+MsQ9MJi0dTAB2IBIq+j+t8PjRLKAdjWhOMgQZs1ZWKicI19APYskbR/SIVD9qYxa zsMVd2JcQj3qngSjhfKpM0rLthm4NL7NGyyr1nhRib7+2phene0fHvoXh+OXej1R8Lu5 TF9Q== X-Gm-Message-State: AKaTC00AgzUISaH77aNBvC10BW3DxvZ1I35yRwc44UPuJDGXbzXLaDxjvptpPcrJ8NLbcQ== X-Received: by 10.55.177.5 with SMTP id a5mr67166572qkf.229.1481148600083; Wed, 07 Dec 2016 14:10:00 -0800 (PST) Received: from wkstn-mjohnston (c-76-104-201-218.hsd1.wa.comcast.net. [76.104.201.218]) by smtp.gmail.com with ESMTPSA id q128sm15812974qka.1.2016.12.07.14.09.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Dec 2016 14:09:59 -0800 (PST) Sender: Mark Johnston Date: Wed, 7 Dec 2016 14:15:49 -0800 From: Mark Johnston To: Gleb Smirnoff Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309658 - head/sys/vm Message-ID: <20161207221548.GA33409@wkstn-mjohnston> References: <201612062252.uB6Mqjhr019191@repo.freebsd.org> <20161207212647.GO27748@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161207212647.GO27748@FreeBSD.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 22:10:01 -0000 On Wed, Dec 07, 2016 at 01:26:47PM -0800, Gleb Smirnoff wrote: > On Tue, Dec 06, 2016 at 10:52:45PM +0000, Mark Johnston wrote: > M> Author: markj > M> Date: Tue Dec 6 22:52:45 2016 > M> New Revision: 309658 > M> URL: https://svnweb.freebsd.org/changeset/base/309658 > M> > M> Log: > M> Provide dummy sysctls for v_cache_count and v_tcached. > M> > M> Some utilities (notably top(1)) exit if any of their input sysctls don't > M> exist, and the removal of the above-mentioned PG_CACHE-related sysctls > M> makes it difficult to run such utilities on different versions of the > M> kernel without recompiling. > M> > M> Requested by: bde > M> > M> Modified: > M> head/sys/vm/vm_meter.c > M> > M> Modified: head/sys/vm/vm_meter.c > M> ============================================================================== > M> --- head/sys/vm/vm_meter.c Tue Dec 6 22:48:28 2016 (r309657) > M> +++ head/sys/vm/vm_meter.c Tue Dec 6 22:52:45 2016 (r309658) > M> @@ -314,3 +314,14 @@ VM_STATS_VM(v_forkpages, "VM pages affec > M> VM_STATS_VM(v_vforkpages, "VM pages affected by vfork()"); > M> VM_STATS_VM(v_rforkpages, "VM pages affected by rfork()"); > M> VM_STATS_VM(v_kthreadpages, "VM pages affected by fork() by kernel"); > M> + > M> +#ifndef BURN_BRIDGES > M> +/* > M> + * Provide compatibility sysctls for the benefit of old utilities which exit > M> + * with an error if they cannot be found. > M> + */ > M> +SYSCTL_UINT(_vm_stats_vm, OID_AUTO, v_cache_count, CTLFLAG_RD, > M> + (u_int *)NULL, 0, "Dummy for compatibility"); > M> +SYSCTL_UINT(_vm_stats_vm, OID_AUTO, v_tcached, CTLFLAG_RD, > M> + (u_int *)NULL, 0, "Dummy for compatibility"); > M> +#endif > > IMHO, there should be some garbage collecting timeout for them. I'd suggest to > delete them from head after stable/12 branch is forked. The intent was to improve compatibility with old userlands, not just to help bridge the transition from 11.0 to 12.0. In general I'm all for removing cruft, but these sysctls are unobtrusive and I don't see any reason to remove them in a specific time frame provided that nothing else breaks compatibility for top(1) (and vmstat(8)). Please feel free to add a timeout if you still disagree, though.