From owner-freebsd-bugs@FreeBSD.ORG  Mon Jul  7 09:16:52 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EFA8F106566C
	for <freebsd-bugs@FreeBSD.org>; Mon,  7 Jul 2008 09:16:52 +0000 (UTC)
	(envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id AF79A8FC13
	for <freebsd-bugs@FreeBSD.org>; Mon,  7 Jul 2008 09:16:52 +0000 (UTC)
	(envelope-from des@des.no)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id 7F6722049
	for <freebsd-bugs@FreeBSD.org>; Mon,  7 Jul 2008 11:01:39 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: freebsd-bugs@FreeBSD.org
References: <200807070253.m672re4a057604@freefall.freebsd.org>
Date: Mon, 07 Jul 2008 11:01:38 +0200
In-Reply-To: <200807070253.m672re4a057604@freefall.freebsd.org>
	(linimon@freebsd.org's message of "Mon\, 7 Jul 2008 02\:53\:40 GMT")
Message-ID: <86abgut6dp.fsf@ds4.des.no>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/23.0.60 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: 
Subject: Re: bin/125350: [libfetch] [patch] src/lib/libfetch add support for
	deflate and gzip encoded http downloads
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jul 2008 09:16:53 -0000

I dislike the idea of nested funopen(); I would much prefer using a
single code path for transfer and content encoding.

openRandom(), httpDecodeRandom() are bad ideas and should not be
implemented.

Support for COMPRESS encoding is unnecessary.  I am not aware of any
HTTP server that implements it, nor of any HTTP server that does not
support DEFLATE (except for those that do not support compression at
all).

The new code needs to conform to the style of the existing code,
i.e. style(9).  This includes changing function names and removing
javadoc metadata.

Adding new .c and .h files is unnecessary, the new code can go in
common.[ch].

Cleaning up http.c is more trouble (and risk) than it's worth.  If it
works, don't fix it.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no