From nobody Sat Nov 8 18:03:25 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d3kLk1cPCz6GM4J; Sat, 08 Nov 2025 18:03:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d3kLk17hQz3l9m; Sat, 08 Nov 2025 18:03:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762625006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YZQGTtBFAwFdtWP2zOzUHoI6J43HY/9AX8L8zSyyTcM=; b=O//1HO5GmwsANcL8dptfX08Dd8znlCBNVaSnJ3sq/XA0qh0SXW/+YGsVmuj+o/neeLnnka ViXPTFAAJenwVleD938VCThhlRrvoS6FCJ+ugivQuXItp0xLaXaCm7H/BuJinOwecNdPbU NRmvt1MjLf9sNJxaRCNhoqAtep8OxlTO7LBGkFO7abKOP6tm+c0tJlFDknLfvuwd60YSM+ sHY+jGEdlfLDU6OMg8EIkXNFdIY1RHnZ3WLYq4+eicKQpCvQ+EDQNoRidb4ygOCTvgneJF HQu1iQ6RhZYPinbFwCw4XUqkmLQPjGsotxTMEm0GhUFg5RagLRLlxvaEaxYf3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762625006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YZQGTtBFAwFdtWP2zOzUHoI6J43HY/9AX8L8zSyyTcM=; b=tz55d36dfMuEnZsoePuGBZoZQZMERjrbul9e3ZO0d5Z5Vfb6yoB+Wc0bFxIxOekH513Rnr /iDcxNPIRLLYSiZ9kw1D4NTgm0bzgJn0cVBQz5ce4SrWm+OEK8ioPK8qiP9fB4YS9VP6hO 207LCWCWsfnUdMm/XLZ6UnPYlAaHgmXIBy6V/+DjmyBKWrrl7IfuWQVHjmE5SEXBZ2qrJs XeXWZvX8V+pWaYzrdJE1POny/5q3s3Xi1tAsoh+WdFrD9HQXG7aJJPpcaxSYwJnqGBrWYj c/7tIQlaR0XsaKAxvx0kM5+BvZmohjfK7GghEOaxi8aYgfK5wSDyh7UXj4deBg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762625006; a=rsa-sha256; cv=none; b=ltU1GvyTdWD09eI3frGiUA0dxXKaH2YzTQBh2kZqiGu28DSgo0/NDOTyiYgQhxMm3O5Wzq f8qMcRyHrIOmlU1UVHeaGMl5rdL+/oEc+RtfHaEKeV8b+pQjJlWeeJLESGc6gcEoqSNV7V LBu8/BSkq/1wmAZzl1vA19t8BB+HPabedQrZX60Jt5nj6A5KcUUu6yavdIGEGSoU/0r9KI rx8OOw10x/cj3Mu7ZrHToY40LWyTA2RHmlxSyoWV018k5W/3ioREWn4/PxWKoh2RPuj3ER 7KBck8sOmOOJpaEb0OmNxMFuVFNhqekSHIQ9KFm8ySGhR8K3T9onW/S/dvV8tw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d3kLk0j2tzvvP; Sat, 08 Nov 2025 18:03:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5A8I3PEj060536; Sat, 8 Nov 2025 18:03:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5A8I3PMs060533; Sat, 8 Nov 2025 18:03:25 GMT (envelope-from git) Date: Sat, 8 Nov 2025 18:03:25 GMT Message-Id: <202511081803.5A8I3PMs060533@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 335fc09ab8d2 - main - netlink: plug lock leak in genl_register_family() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 335fc09ab8d25c3ced027d46f5a0f4103d5c8bee Auto-Submitted: auto-generated The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=335fc09ab8d25c3ced027d46f5a0f4103d5c8bee commit 335fc09ab8d25c3ced027d46f5a0f4103d5c8bee Author: Bruno Silvestre AuthorDate: 2025-11-08 18:02:32 +0000 Commit: Gleb Smirnoff CommitDate: 2025-11-08 18:02:32 +0000 netlink: plug lock leak in genl_register_family() PR: 290893 --- sys/netlink/netlink_generic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/netlink/netlink_generic.c b/sys/netlink/netlink_generic.c index 00f47e60f013..d20ec4c7545f 100644 --- a/sys/netlink/netlink_generic.c +++ b/sys/netlink/netlink_generic.c @@ -366,8 +366,10 @@ genl_register_family(const char *family_name, size_t hdrsize, GENL_LOCK(); for (u_int i = 0; i < MAX_FAMILIES; i++) if (families[i].family_name != NULL && - strcmp(families[i].family_name, family_name) == 0) + strcmp(families[i].family_name, family_name) == 0) { + GENL_UNLOCK(); return (0); + } /* Microoptimization: index 0 is reserved for the control family. */ gf = NULL;