From owner-svn-src-projects@freebsd.org Sat Aug 27 00:58:31 2016 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0918EA944E2 for ; Sat, 27 Aug 2016 00:58:31 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qt0-x233.google.com (mail-qt0-x233.google.com [IPv6:2607:f8b0:400d:c0d::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B4A50191; Sat, 27 Aug 2016 00:58:30 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qt0-x233.google.com with SMTP id 93so46048370qtg.2; Fri, 26 Aug 2016 17:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2patMu0LgwTZ9Iy11m4qkbOKiPEgwKWCagB69eQPPqA=; b=IldXk24INqn1DdSy3m+r0EeZoLofYYPeU/DndcHIcEVtRWOqk3kQ/mHRmMyIyRqrjE 8e9rt2/GofMK4HXdLgIMWEOaX0WoCahFH1ojjeKaPD5voZorx03dp6jECcURuj5kd+XT AYn51JnXbZA1VFg2JPc/zwn7dafCwUNcrU1DZKS6kVYiG/zmX9ehM+Qu3oU3BHD4UNWx uar/DB3xePGt927aiFnX2rFmFni5Sv78EZNY9tUohl3U8JA0jqf5X1WQQXv0abQG/DGq WZPc8bqiGcubcIhz7e28ApOVi85n/N4ejJ0xVv5XhOfO69wkfLGe2HTo6DS/aIiUEEuN JA0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2patMu0LgwTZ9Iy11m4qkbOKiPEgwKWCagB69eQPPqA=; b=SZknaA0uR+PHhLZDp2oByS4HMsP4Zf/8kFgIKirfEElo5b2tj9zYylagF0eGx9EEtB NePJS87e2YAddItHuHFvKrsFEzKQtUJ5UL8YH/oVFF7DvB85nv7GeJCIIc2tSwp8Vkvy ahpLtDzsJcU01lK4ApYBc47ClNDKBuwH7lLFdwxxxA/AmnV3q0hZ1HmouzV8f+qPNBzm OD49hP3Y8szPOHKHAdLrDlZs/fRfmsDcZUpPeCiymNbS9X2oPRfYFul6zjoxjnnUWR8u huUSkB5eBX4HThsZhQ+7HruFWc4CISB/EpPT3vwDZPKHcXSdQcirqC26i+VU0FBTxfSo nNsg== X-Gm-Message-State: AE9vXwNtpBGGrA53yBJdvkLH0CtKLav4rKWJ340WJztTbNac0ykUYU9saQbUzeC5M8ECDBlTU+2o+AmCn6AyVQ== X-Received: by 10.200.48.112 with SMTP id g45mr6561295qte.70.1472259509347; Fri, 26 Aug 2016 17:58:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.182.134 with HTTP; Fri, 26 Aug 2016 17:58:28 -0700 (PDT) In-Reply-To: References: <201608262256.u7QMuNaZ037409@repo.freebsd.org> From: Ngie Cooper Date: Fri, 26 Aug 2016 17:58:28 -0700 Message-ID: Subject: Re: svn commit: r304868 - projects/clang390-import/lib/clang To: Dimitry Andric Cc: "src-committers@freebsd.org" , "svn-src-projects@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Aug 2016 00:58:31 -0000 On Fri, Aug 26, 2016 at 4:39 PM, Dimitry Andric wrote: ... > I used ${SRCTOP} and ${OBJTOP} initially, until I realized that the > latter didn't work for builds which are started during bootstrap-tools. > So I locally reverted all these changes before committing this WIP. > > That said, ${SRCTOP} makes it look a little nicer, but there are lots > of other instances of using ../../.. in these Makefiles. It does not > really bother me. :) Can you use something like this instead to signal the "right intent", and someday hopefully this will just work (tm) with a bit more effort? Thanks, -Ngie # XXX: SRCTOP isn't available until Y stage in the build SRCTOP?= ${.CURDIR:H:H} LLVM_SRCS= ${SRCTOP}/contrib/llvm